More clean up.

Author: samuel-williams-shopify

benchmark/array.rb

@@ -0,0 +1,26 @@
+# frozen_string_literal: true
+
+# Released under the MIT License.
+# Copyright, 2025, by Samuel Williams.
+
+require "sus/fixtures/benchmark"
+
+describe "Array initialization" do
+	include Sus::Fixtures::Benchmark
+	
+	let(:source_array) {["value1", "value2", "value3", "value4", "value5"]}
+	
+	measure "Array.new(array)" do |repeats|
+		repeats.times do
+			Array.new(source_array)
+		end
+	end
+	
+	measure "Array.new.concat(array)" do |repeats|
+		repeats.times do
+			array = Array.new
+			array.concat(source_array)
+		end
+	end
+end
+

gems.rb

@@ -29,6 +29,7 @@
 	gem "rubocop-socketry"
 
 	gem "sus-fixtures-async"
+	gem "sus-fixtures-benchmark"
 
 	gem "bake-test"
 	gem "bake-test-external"

lib/protocol/http/header/accept.rb

@@ -68,52 +68,26 @@ def quality_factor
 					end
 				end
 
-				# Parses a raw header value from the wire.
+				# Parses a raw header value.
 				#
-				# @parameter value [String] the raw header value containing comma-separated media types.
+				# @parameter value [String] a raw header value containing comma-separated media types.
 				# @returns [Accept] a new instance containing the parsed media types.
 				def self.parse(value)
 					self.new(value.scan(SEPARATOR).map(&:strip))
 				end
 
-				# Coerces a value into a parsed header object.
-				#
-				# @parameter value [String | Array] the value to coerce.
-				# @returns [Accept] a parsed header object.
-				def self.coerce(value)
-					case value
-					when Array
-						self.new(value.map(&:to_s))
-					else
-						self.parse(value.to_s)
-					end
-				end
-				
-				# Initializes an Accept header with already-parsed values.
-				#
-				# @parameter value [Array | Nil] an array of parsed media type strings, or `nil` for an empty header.
-				def initialize(value = nil)
-					if value.is_a?(Array)
-						super(value)
-					elsif value.is_a?(String)
-						super(value)
-					elsif value
-						raise ArgumentError, "Invalid value: #{value.inspect}"
-					end
-				end
-				
-				# Adds one or more comma-separated values to the header from a raw wire-format string.
+				# Adds one or more comma-separated values to the header.
 				#
 				# The input string is split into distinct entries and appended to the array.
 				#
-				# @parameter value [String] a raw wire-format value containing one or more media types separated by commas.
+				# @parameter value [String] a raw header value containing one or more media types separated by commas.
 				def << value
 					self.concat(value.scan(SEPARATOR).map(&:strip))
 				end
 
-				# Converts the parsed header value into a raw wire-format string.
+				# Converts the parsed header value into a raw header value.
 				#
-				# @returns [String] a raw wire-format value (comma-separated string) suitable for transmission.
+				# @returns [String] a raw header value (comma-separated string).
 				def to_s
 					join(",")
 				end

lib/protocol/http/header/authorization.rb

@@ -15,9 +15,9 @@ module Header
 			#
 			# TODO Support other authorization mechanisms, e.g. bearer token.
 			class Authorization < String
-				# Parses a raw header value from the wire.
+				# Parses a raw header value.
 				#
-				# @parameter value [String] the raw header value.
+				# @parameter value [String] a raw header value.
 				# @returns [Authorization] a new instance.
 				def self.parse(value)
 					self.new(value)
@@ -47,8 +47,8 @@ def self.basic(username, password)
 					strict_base64_encoded = ["#{username}:#{password}"].pack("m0")
 
 					self.new(
-						"Basic #{strict_base64_encoded}"
-					)
+								"Basic #{strict_base64_encoded}"
+							)
 				end
 
 				# Whether this header is acceptable in HTTP trailers.

lib/protocol/http/header/cache_control.rb

@@ -44,24 +44,44 @@ class CacheControl < Split
 				# The `proxy-revalidate` directive is similar to `must-revalidate` but applies only to shared caches.
 				PROXY_REVALIDATE = "proxy-revalidate"
 
-				# Initializes the cache control header with already-parsed and normalized values.
+				# Parses a raw header value.
 				#
-				# @parameter value [Array | Nil] an array of normalized (lowercase) directives, or `nil` for an empty header.
+				# @parameter value [String] a raw header value containing comma-separated directives.
+				# @returns [CacheControl] a new instance containing the parsed and normalized directives.
+				def self.parse(value)
+					self.new(value.downcase.split(COMMA))
+				end
+				
+				# Coerces a value into a parsed header object.
+				#
+				# @parameter value [String | Array] the value to coerce.
+				# @returns [CacheControl] a parsed header object with normalized values.
+				def self.coerce(value)
+					case value
+					when Array
+						self.new(value.map(&:downcase))
+					else
+						self.parse(value.to_s)
+					end
+				end
+				
+				# Initializes the cache control header with the given values.
+				#
+				# @parameter value [Array | String | Nil] an array of directives, a raw header value, or `nil` for an empty header.
 				def initialize(value = nil)
 					if value.is_a?(Array)
-						super(value.map(&:downcase))
+						super(value)
 					elsif value.is_a?(String)
-						# Compatibility with the old constructor, prefer to use `parse` instead:
 						super()
 						self << value
 					elsif value
 						raise ArgumentError, "Invalid value: #{value.inspect}"
 					end
 				end
 
-				# Adds a directive to the Cache-Control header from a raw wire-format string. The value will be normalized to lowercase before being added.
+				# Adds a directive to the Cache-Control header. The value will be normalized to lowercase before being added.
 				#
-				# @parameter value [String] a raw wire-format directive to add.
+				# @parameter value [String] a raw header value containing directives to add.
 				def << value
 					super(value.downcase)
 				end

lib/protocol/http/header/connection.rb

@@ -22,23 +22,44 @@ class Connection < Split
 				# The `upgrade` directive indicates that the connection should be upgraded to a different protocol, as specified in the `Upgrade` header.
 				UPGRADE = "upgrade"
 
-				# Initializes the connection header with already-parsed and normalized values.
+				# Parses a raw header value.
 				#
-				# @parameter value [Array | Nil] an array of normalized (lowercase) directives, or `nil` for an empty header.
+				# @parameter value [String] a raw header value containing comma-separated directives.
+				# @returns [Connection] a new instance with normalized (lowercase) directives.
+				def self.parse(value)
+					self.new(value.downcase.split(COMMA))
+				end
+				
+				# Coerces a value into a parsed header object.
+				#
+				# @parameter value [String | Array] the value to coerce.
+				# @returns [Connection] a parsed header object with normalized values.
+				def self.coerce(value)
+					case value
+					when Array
+						self.new(value.map(&:downcase))
+					else
+						self.parse(value.to_s)
+					end
+				end
+				
+				# Initializes the connection header with the given values.
+				#
+				# @parameter value [Array | String | Nil] an array of directives, a raw header value, or `nil` for an empty header.
 				def initialize(value = nil)
 					if value.is_a?(Array)
-						super(value.map(&:downcase))
-					elsif value.is_a?(String)
-						# Compatibility with the old constructor, prefer to use `parse` instead:
 						super(value)
+					elsif value.is_a?(String)
+						super()
+						self << value
 					elsif value
 						raise ArgumentError, "Invalid value: #{value.inspect}"
 					end
 				end
 
-				# Adds a directive to the `connection` header from a raw wire-format string. The value will be normalized to lowercase before being added.
+				# Adds a directive to the `connection` header. The value will be normalized to lowercase before being added.
 				#
-				# @parameter value [String] a raw wire-format directive to add.
+				# @parameter value [String] a raw header value containing directives to add.
 				def << value
 					super(value.downcase)
 				end

lib/protocol/http/header/date.rb

@@ -12,9 +12,9 @@ module Header
 			#
 			# This header is typically included in HTTP responses and follows the format defined in RFC 9110.
 			class Date < String
-				# Parses a raw header value from the wire.
+				# Parses a raw header value.
 				#
-				# @parameter value [String] the raw header value.
+				# @parameter value [String] a raw header value.
 				# @returns [Date] a new instance.
 				def self.parse(value)
 					self.new(value)
@@ -28,9 +28,9 @@ def self.coerce(value)
 					self.new(value.to_s)
 				end
 
-				# Replaces the current value of the `date` header with a raw wire-format string.
+				# Replaces the current value of the `date` header.
 				#
-				# @parameter value [String] a raw wire-format value for the `date` header.
+				# @parameter value [String] a raw header value for the `date` header.
 				def << value
 					replace(value)
 				end

lib/protocol/http/header/etag.rb

@@ -10,9 +10,9 @@ module Header
 			#
 			# The `etag` header provides a unique identifier for a specific version of a resource, typically used for cache validation or conditional requests. It can be either a strong or weak validator as defined in RFC 9110.
 			class ETag < String
-				# Parses a raw header value from the wire.
+				# Parses a raw header value.
 				#
-				# @parameter value [String] the raw header value.
+				# @parameter value [String] a raw header value.
 				# @returns [ETag] a new instance.
 				def self.parse(value)
 					self.new(value)
@@ -26,9 +26,9 @@ def self.coerce(value)
 					self.new(value.to_s)
 				end
 
-				# Replaces the current value of the `etag` header with a raw wire-format string.
+				# Replaces the current value of the `etag` header.
 				#
-				# @parameter value [String] a raw wire-format value for the `etag` header.
+				# @parameter value [String] a raw header value for the `etag` header.
 				def << value
 					replace(value)
 				end

lib/protocol/http/header/multiple.rb

@@ -10,11 +10,11 @@ module Header
 			#
 			# This isn't a specific header but is used as a base for headers that store multiple values, such as cookies. The values are split and stored as an array internally, and serialized back to a newline-separated string when needed.
 			class Multiple < Array
-				# Parses a raw header value from the wire.
+				# Parses a raw header value.
 				#
-				# Multiple headers receive each value as a separate header entry on the wire, so this method takes a single string value and creates a new instance containing it.
+				# Multiple headers receive each value as a separate header entry, so this method takes a single string value and creates a new instance containing it.
 				#
-				# @parameter value [String] a single raw header value from the wire.
+				# @parameter value [String] a single raw header value.
 				# @returns [Multiple] a new instance containing the parsed value.
 				def self.parse(value)
 					self.new([value])
@@ -46,11 +46,11 @@ def initialize(value = nil)
 					end
 				end
 
-				# Converts the parsed header value into a raw wire-format string.
+				# Converts the parsed header value into a raw header value.
 				#
-				# Multiple headers are transmitted as separate header entries on the wire, so this serializes to a newline-separated string for storage.
+				# Multiple headers are transmitted as separate header entries, so this serializes to a newline-separated string for storage.
 				#
-				# @returns [String] a raw wire-format value (newline-separated string).
+				# @returns [String] a raw header value (newline-separated string).
 				def to_s
 					join("\n")
 				end

lib/protocol/http/header/priority.rb

@@ -12,24 +12,44 @@ module Header
 			#
 			# The `priority` header allows clients to express their preference for how resources should be prioritized by the server. It supports directives like `u=` to specify the urgency level of a request, and `i` to indicate whether a response can be delivered incrementally. The urgency levels range from 0 (highest priority) to 7 (lowest priority), while the `i` directive is a boolean flag.
 			class Priority < Split
-				# Initializes the priority header with already-parsed and normalized values.
+				# Parses a raw header value.
 				#
-				# @parameter value [Array | Nil] an array of normalized (lowercase) directives, or `nil` for an empty header.
+				# @parameter value [String] a raw header value containing comma-separated directives.
+				# @returns [Priority] a new instance with normalized (lowercase) directives.
+				def self.parse(value)
+					self.new(value.downcase.split(COMMA))
+				end
+				
+				# Coerces a value into a parsed header object.
+				#
+				# @parameter value [String | Array] the value to coerce.
+				# @returns [Priority] a parsed header object with normalized values.
+				def self.coerce(value)
+					case value
+					when Array
+						self.new(value.map(&:downcase))
+					else
+						self.parse(value.to_s)
+					end
+				end
+				
+				# Initializes the priority header with the given values.
+				#
+				# @parameter value [Array | String | Nil] an array of directives, a raw header value, or `nil` for an empty header.
 				def initialize(value = nil)
 					if value.is_a?(Array)
-						super(value.map(&:downcase))
+						super(value)
 					elsif value.is_a?(String)
-						# Compatibility with the old constructor, prefer to use `parse` instead:
 						super()
 						self << value
 					elsif value
 						raise ArgumentError, "Invalid value: #{value.inspect}"
 					end
 				end
 
-				# Add a value to the priority header from a raw wire-format string.
+				# Add a value to the priority header.
 				#
-				# @parameter value [String] a raw wire-format directive to add to the header.
+				# @parameter value [String] a raw header value containing directives to add to the header.
 				def << value
 					super(value.downcase)
 				end