Ensure connections are marked not persistent when 1xx or body is Remainder. (#26)

Author: zarqman

lib/protocol/http1/connection.rb

@@ -423,6 +423,7 @@ def read_fixed_body(length)
 			end
 
 			def read_remainder_body
+				@persistent = false
 				Body::Remainder.new(@stream)
 			end
 
@@ -469,7 +470,14 @@ def read_response_body(method, status, headers)
 					return nil
 				end
 
-				if (status >= 100 and status < 200) or status == 204 or status == 304
+				if status >= 100 and status < 200
+					# At the moment this is returned, the Remainder represents any
+					# future response on the stream. The Remainder may be used directly
+					# or discarded, or read_response may be called again.
+					return read_remainder_body
+				end
+				
+				if status == 204 or status == 304
 					return nil
 				end
 

test/protocol/http1/connection.rb

@@ -204,7 +204,9 @@
 	with '#read_response_body' do
 		with "GET" do
 			it "should ignore body for informational responses" do
-				expect(client.read_response_body("GET", 100, {'content-length' => '10'})).to be_nil
+				body = client.read_response_body("GET", 100, {'content-length' => '10'})
+				expect(body).to be_a(::Protocol::HTTP1::Body::Remainder)
+				expect(client.persistent).to be == false
 			end
 
 			it "should ignore body for no content responses" do
@@ -214,6 +216,7 @@
 			it "should handle non-chunked transfer-encoding" do
 				body = client.read_response_body("GET", 200, {'transfer-encoding' => ['identity']})
 				expect(body).to be_a(::Protocol::HTTP1::Body::Remainder)
+				expect(client.persistent).to be == false
 			end
 
 			it "should be an error if both transfer-encoding and content-length is set" do

test/protocol/http1/hijack.rb

@@ -45,7 +45,7 @@
 			expect(headers).to have_keys(
 				'upgrade' => be == ['websocket'],
 			)
-			expect(body).to be_nil # due to 101 status
+			expect(body).to be_a(::Protocol::HTTP1::Body::Remainder) # due to 101 status
 
 			client_stream = client.hijack!