Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add copyright file and codestyle for develop #299

Open
mxsm opened this issue Jul 17, 2022 · 3 comments · May be fixed by #300
Open

Add copyright file and codestyle for develop #299

mxsm opened this issue Jul 17, 2022 · 3 comments · May be fixed by #300

Comments

@mxsm
Copy link

mxsm commented Jul 17, 2022

Is your feature request related to a problem? Please describe.

need a copyright component and sofa-bolt codestyle for this project. Facilitate contributors' participation in the project

Describe the solution you'd like

make style folder, and add file for copyright , a file for codestyle

<!--
  Licensed to the Apache Software Foundation (ASF) under one or more
  contributor license agreements.  See the NOTICE file distributed with
  this work for additional information regarding copyright ownership.
  The ASF licenses this file to You under the Apache License, Version 2.0
  (the "License"); you may not use this file except in compliance with
  the License.  You may obtain a copy of the License at

      http://www.apache.org/licenses/LICENSE-2.0

  Unless required by applicable law or agreed to in writing, software
  distributed under the License is distributed on an "AS IS" BASIS,
  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  See the License for the specific language governing permissions and
  limitations under the License.
  -->

<component name="CopyrightManager">
    <copyright>
        <option name="sofa-bolt" value="Apache" />
        <option name="notice" value="Licensed to the Apache Software Foundation (ASF) under one or more&#10;contributor license agreements.  See the NOTICE file distributed with&#10;this work for additional information regarding copyright ownership.&#10;The ASF licenses this file to You under the Apache License, Version 2.0&#10;(the &quot;License&quot;); you may not use this file except in compliance with&#10;the License.  You may obtain a copy of the License at&#10;&#10;    http://www.apache.org/licenses/LICENSE-2.0&#10;&#10;Unless required by applicable law or agreed to in writing, software&#10;distributed under the License is distributed on an &quot;AS IS&quot; BASIS,&#10;WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.&#10;See the License for the specific language governing permissions and&#10;limitations under the License." />
    </copyright>
</component>

developer can import this file to IDEA, When create java file the copyright will add in java file head

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.
@mxsm
Copy link
Author

mxsm commented Jul 17, 2022

code style file can create like RocketMQ code style , and adjust according to this project. Import the file to IDEA and then the developer can formate the code according to the imported code style file. convenient!!!!

@chuailiwu
Copy link
Collaborator

RocketMQ code style

can you submit a pull request for it?

@mxsm
Copy link
Author

mxsm commented Jul 28, 2022

RocketMQ code style

can you submit a pull request for it?

I will submit a PR for this

mxsm added a commit to mxsm/sofa-bolt that referenced this issue Jul 28, 2022
@mxsm
[ISSUE sofastack#299]Add copyright file and codestyle for develop
1672b48
@mxsm mxsm linked a pull request Jul 28, 2022 that will close this issue
Open
mxsm added a commit to mxsm/sofa-bolt that referenced this issue Aug 11, 2022
@mxsm
[ISSUE sofastack#299]Add copyright file and codestyle for develop
05c6a7d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ISSUE #299]Add copyright file and codestyle for develop mxsm/sofa-bolt
2 participants
@chuailiwu @mxsm