Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using data before the request completes #29

Open
oliverjam opened this issue Aug 5, 2020 · 2 comments
Open

Using data before the request completes #29

oliverjam opened this issue Aug 5, 2020 · 2 comments

Comments

@oliverjam
Copy link
Collaborator

Without fail at least half of every cohort get stuck with this destructuring error. I wonder if it's actually useful to force them to encounter it? Maybe if we framed it more deliberately so they're expecting it?

Now you might be seeing something! If not, that's fine, you've followed instructions correctly.

This isn't technically true: they should definitely be seeing an error at this point. It might be better to say something like "Now let's try accessing the data—this won't work at first, and we'll find out why after." Then get them to try and see the data isn't there yet.

@sofiapoh
Copy link
Owner

sofiapoh commented Aug 5, 2020

I completely forgot about this annoying part. I'll make a clarification that they'll definitely see an error first. It's probably worth showing it so they get some exposure to what that sort of error may look like? Not sure!

@oliverjam
Copy link
Collaborator Author

Yeah I think it's fine as long as we make it clear they'll have an error before we get them to write the code. People often hit the error and get stuck debugging and never read the following section.

It would also be good to have them log the data in the component's render so they can see it is null at first.

oliverjam added a commit to oliverjam/react-dynamic-data-workshop that referenced this issue Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants