Skip to content

update subnet ordering code #2085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
allmightyspiff opened this issue Sep 8, 2023 · 1 comment
Closed

update subnet ordering code #2085

allmightyspiff opened this issue Sep 8, 2023 · 1 comment
Assignees

Comments

@allmightyspiff
Copy link
Member

allmightyspiff commented Sep 8, 2023

https://softlayer-python.readthedocs.io/en/latest/_modules/SoftLayer/managers/network/#NetworkManager.add_subnet

Changes to how routing works means there isn't much difference between static and portable subnets anymore. Private and Public subnets can be both routed to an IP or routed to a vlan, so we need to allow for that.

TODO

  • When ordering vlan, just use the PORTABLE_IP_ADDRESSES to find price ids
$> slcli order item-list PORTABLE_IP_ADDRESSES
┌───────────────────────────┬─────────────────────────────────────────┬──────────────────────────────────────────┬──────────┐
│         Category          │                 KeyName                 │               Description                │ Price Id │
├───────────────────────────┼─────────────────────────────────────────┼──────────────────────────────────────────┼──────────┤
│ sov_sec_ip_addresses_priv │    128_PORTABLE_PRIVATE_IP_ADDRESSES    │    128 Portable Private IP Addresses     │  37054   │
│ sov_sec_ip_addresses_priv │    16_PORTABLE_PRIVATE_IP_ADDRESSES     │     16 Portable Private IP Addresses     │  13982   │
│ sov_sec_ip_addresses_priv │          1_PORTABLE_PRIVATE_IP          │      1 Portable Private IP Address       │  229161  │
│ sov_sec_ip_addresses_priv │      2_PORTABLE_PRIVATE_IP_ADDRESS      │      2 Portable Private IP Address       │  291372  │
│ sov_sec_ip_addresses_priv │     8_PORTABLE_PRIVATE_IP_ADDRESSES     │     8 Portable Private IP Addresses      │  13935   │
│ sov_sec_ip_addresses_priv │    256_PORTABLE_PRIVATE_IP_ADDRESSES    │    256 Portable Private IP Addresses     │  21177   │
│ sov_sec_ip_addresses_priv │    32_PORTABLE_PRIVATE_IP_ADDRESSES     │     32 Portable Private IP Addresses     │  13997   │
│ sov_sec_ip_addresses_priv │    64_PORTABLE_PRIVATE_IP_ADDRESSES     │     64 Portable Private IP Addresses     │  14050   │
│ sov_sec_ip_addresses_priv │     4_PORTABLE_PRIVATE_IP_ADDRESSES     │     4 Portable Private IP Addresses      │  13981   │
│ sov_sec_ip_addresses_pub  │     4_PORTABLE_PUBLIC_IP_ADDRESSES      │      4 Portable Public IP Addresses      │  13980   │
│ sov_sec_ip_addresses_pub  │     2_PORTABLE_PUBLIC_IP_ADDRESSES      │      2 Portable Public IP Addresses      │  180757  │
│ sov_sec_ip_addresses_pub  │     64_PORTABLE_PUBLIC_IP_ADDRESSES     │     64 Portable Public IP Addresses      │  21767   │
│ sov_sec_ip_addresses_pub  │    128_PORTABLE_PUBLIC_IP_ADDRESSES     │     128 Portable Public IP Addresses     │  22341   │
│ sov_sec_ip_addresses_pub  │    256_PORTABLE_PUBLIC_IP_ADDRESSES     │     256 Portable Public IP Addresses     │  44758   │
│ sov_sec_ip_addresses_pub  │     16_PORTABLE_PUBLIC_IP_ADDRESSES     │     16 Portable Public IP Addresses      │  13978   │
│ sov_sec_ip_addresses_pub  │     32_PORTABLE_PUBLIC_IP_ADDRESSES     │     32 Portable Public IP Addresses      │  14049   │
│ sov_sec_ip_addresses_pub  │      1_PORTABLE_PUBLIC_IP_ADDRESS       │       1 Portable Public IP Address       │  180483  │
│ sov_sec_ip_addresses_pub  │     8_PORTABLE_PUBLIC_IP_ADDRESSES      │      8 Portable Public IP Addresses      │  13934   │
│   static_ipv6_addresses   │ 64_BLOCK_PORTABLE_PUBLIC_IPV6_ADDRESSES │ /64 Block Portable Public IPv6 Addresses │   1482   │
└───────────────────────────┴─────────────────────────────────────────┴──────────────────────────────────────────┴──────────┘

  • allow user to specify if they are routing to a vlan, subnet, or datacenter (basically the "none" option in the portal)
    image

  • Make sure the slcli subnet add command is changed accordingly.

https://sldn.softlayer.com/reference/datatypes/SoftLayer_Container_Product_Order_Network_Subnet/#endPointVlanId
https://sldn.softlayer.com/reference/datatypes/SoftLayer_Container_Product_Order_Network_Subnet/#endPointIpAddressId

@allmightyspiff allmightyspiff self-assigned this Sep 8, 2023
@allmightyspiff allmightyspiff moved this to Done in 2025 Jan 8, 2025
@allmightyspiff allmightyspiff closed this as completed by moving to Done in 2025 Jan 8, 2025
@allmightyspiff
Copy link
Member Author

subnet create uses portable ip addresses. While there is no option to route at order time, customers can use the subnet route command to do so afterwards, which I think is ok given how much more complicated doing so at order time would make things.

@allmightyspiff allmightyspiff closed this as not planned Won't fix, can't repro, duplicate, stale Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

1 participant