Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use newtypes for IDs #290

Open
rocallahan opened this issue Apr 21, 2021 · 0 comments
Open

Use newtypes for IDs #290

rocallahan opened this issue Apr 21, 2021 · 0 comments
Labels
enhancement

Comments

@rocallahan
Copy link
Contributor

💡 Feature description

The API would be slightly safer to use if IDs (e.g. CheckRun IDs were exposed as newtypes, e.g. CheckRunId, instead of a raw integer.

Would this change be acceptable? It would be an API-breaking change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rocallahan