Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback Lab 1 #7

Open
ana-oprescu opened this issue Sep 20, 2017 · 0 comments
Open

Feedback Lab 1 #7

ana-oprescu opened this issue Sep 20, 2017 · 0 comments

Comments

@ana-oprescu
Copy link

Exercise 1 Comments Exercise 2 Comments Exercise 3 Comments Exercise 4 Comments Exercise 5 Comments Exercise 6 Comments Exercise 7 Comments Exercise 8 Comments Bonus Exercise 9 Comments Bonus Exercise 10 Comments Total
7 No discussion on why this solution was selected, no quickcheck test included 7 No discussion on why this solution was selected, no quickcheck test included 6 No discussion on why this solution was selected, no quickcheck test included. You are returning true if the number is negative. You may want to avoid testing for negative numbers (pre-condition) 10 Nice structured solution and answers 9 Maybe you need to clarify that you are relying on already implemented functions 10 Perfect 9 You could have added some testable properties for helper functions (e.g., turning digits to integers and back); the test does not report on how many testcases were used; well done testing automatically both valid and invalid testcases 6 -> issues 7 Euler 9 ok; Euler 10 ok; 5 Euler 49: you do not argue why the same 3330 step would apply for the solution tuple as well 8.6
-- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant