Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback Lab 1 #2

Open
ana-oprescu opened this issue Sep 19, 2017 · 0 comments
Open

Feedback Lab 1 #2

ana-oprescu opened this issue Sep 19, 2017 · 0 comments

Comments

@ana-oprescu
Copy link

Exercise 1 Comments Exercise 2 Comments Exercise 3 Comments Exercise 4 Comments Exercise 5 Comments Exercise 6 Comments Exercise 7 Comments Exercise 8 Comments Bonus Exercise 9 Comments Bonus Exercise 10 Comments Total
9 Not discussing about why they select this approach among others 9 Justification about why the solution was selected is missing 8 Justification of the selection missing.Second answer is kind of unclear 6 Function testing is missing 9 Good answers: Maybe you may want to print which numbers produces the printed value 8 A more efficient implementation is possible 9 You could have added some testable properties for helper functions (e.g., turning digits to integers and back); you could also generate the invalid testcases 9 -> issues 6 very cumbersome implementation for 9; how about using list comprehension and triangle properties:triplets n = [ (a,b,c) | c <-[1..n], a <- [1..c], b <- [1..c], a < b, a^2 + b^2 == c^2 ] 6 ex 49 uses the difference 3330 although the problem does not state that the difference should occur in the other solution. 8.975
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant