Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recording controls enhancement #733

Open
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

p-malecki
Copy link
Contributor

This PR introduces recording controls enhancement:

  • introduces a toggle button to start/stop recordings
  • opens a save dialog immediately after pressing stop (in future, we could reuse replayOverlay for video previews and edits)
  • ignores and does not save recordings under 1 second
  • adds a maximum limit of 5 minutes for recordings, after which it automatically pauses and opens the save dialog
  • adds timestamps to the filenames of video recordings
  • eliminates text labels from the Replay and Logs buttons to create more space in the top button group
  • updates the Replay button icon

Test plan:

  1. Start a recording, interact with the test app, then stop the recording after a few seconds and save the file to a selected location. Open the saved recording to verify that the app's screen was correctly captured.
  2. Start a recording and stop it immediately to confirm that the save dialog does not appear for recordings under 1 second.
  3. Test the maximum recording time to ensure that it automatically stops and opens the save dialog after the 5-minute limit is reached.
  4. Ensure that the Replay button is disabled during recording.
  5. After capturing a recording, test the Replay functionality to ensure it still works correctly.
  6. Verify that the timestamps on the recorded video filenames reflect the correct date and time, matching the system clock.

Before:
Screenshot 2024-11-15 at 17 22 48

After:
Screenshot 2024-11-15 at 17 23 34
Screenshot 2024-11-15 at 17 23 57

Screen.Recording.2024-11-15.at.17.56.24.mov

resolves: #708

Copy link

vercel bot commented Nov 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
radon-ide ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2024 6:09pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add controls for normal screen recording (start / stop)
1 participant