Apply review suggestions

Author: IgorSwat

docs/docs/04-typescript-api/01-natural-language-processing/TextToSpeechModule.md

@@ -105,11 +105,11 @@ const audioContext = new AudioContext({ sampleRate: 44100 });
 
 try {
   const waveform = await tts.forward(
-    'Hello from ExecuTorch!',
-    1.0,
-    true,
-    8,
-    'en'
+    'Hello from ExecuTorch!', // Input text
+    1.0, // Speed
+    true, // Phonemize the input (Kokoro only)
+    8, // Number of steps (Supertonic only)
+    'en' // Language (Supertonic only)
   );
   // Kokoro: tts.forward('Hello from ExecuTorch!', 1.0)
 

packages/react-native-executorch/common/rnexecutorch/host_objects/ModelHostObject.h

@@ -219,24 +219,8 @@ template <typename Model> class ModelHostObject : public JsiHostObject {
           JSI_EXPORT_FUNCTION(ModelHostObject<Model>, unload, "unload"));
     }
 
-    if constexpr (meta::SameAs<Model, models::text_to_speech::kokoro::Kokoro>) {
-      addFunctions(
-          JSI_EXPORT_FUNCTION(ModelHostObject<Model>, unload, "unload"));
-      addFunctions(JSI_EXPORT_FUNCTION(ModelHostObject<Model>,
-                                       promiseHostFunction<&Model::stream>,
-                                       "stream"));
-      addFunctions(JSI_EXPORT_FUNCTION(
-          ModelHostObject<Model>, synchronousHostFunction<&Model::streamStop>,
-          "streamStop"));
-      addFunctions(JSI_EXPORT_FUNCTION(
-          ModelHostObject<Model>, synchronousHostFunction<&Model::streamInsert>,
-          "streamInsert"));
-      addFunctions(JSI_EXPORT_FUNCTION(
-          ModelHostObject<Model>, synchronousHostFunction<&Model::streamFlush>,
-          "streamFlush"));
-    }
-
-    if constexpr (meta::SameAs<
+    if constexpr (meta::SameAs<Model, models::text_to_speech::kokoro::Kokoro> ||
+                  meta::SameAs<
                       Model, models::text_to_speech::supertonic::Supertonic>) {
       addFunctions(
           JSI_EXPORT_FUNCTION(ModelHostObject<Model>, unload, "unload"));

packages/react-native-executorch/common/rnexecutorch/models/text_to_speech/common/Constants.h

@@ -24,4 +24,4 @@ inline const std::unordered_set<char32_t> kPauseCharacters = {
     U'»', // Right Guillemet (U+00BB)
 };
 
-} // namespace rnexecutorch::models::text_to_speech::constants
+} // namespace rnexecutorch::models::text_to_speech::constants

packages/react-native-executorch/common/rnexecutorch/models/text_to_speech/common/TextPartitioner.cpp

@@ -102,4 +102,4 @@ TextPartitioner::Partition TextPartitioner::partition(std::u32string_view input,
   return {input, std::move(segments)};
 }
 
-} // namespace rnexecutorch::models::text_to_speech
+} // namespace rnexecutorch::models::text_to_speech

packages/react-native-executorch/common/rnexecutorch/models/text_to_speech/common/TextPartitioner.h

@@ -75,7 +75,7 @@ class TextPartitioner {
         segments; // Pairs of {offset, length} for each segment.
   };
 
-  TextPartitioner(const TextPartitionerConfig &config);
+  explicit TextPartitioner(const TextPartitionerConfig &config);
 
   /**
    * Partitions the input text into segments.
@@ -91,4 +91,4 @@ class TextPartitioner {
   TextPartitionerConfig config_;
 };
 
-} // namespace rnexecutorch::models::text_to_speech
+} // namespace rnexecutorch::models::text_to_speech

packages/react-native-executorch/common/rnexecutorch/models/text_to_speech/common/Utils.cpp

@@ -66,4 +66,4 @@ std::span<const float> stripAudio(std::span<const float> audio, size_t margin,
   return audio.subspan(lbound, strippedLength);
 }
 
-} // namespace rnexecutorch::models::text_to_speech::utils
+} // namespace rnexecutorch::models::text_to_speech::utils

packages/react-native-executorch/common/rnexecutorch/models/text_to_speech/common/Utils.h

@@ -18,4 +18,4 @@ std::span<const float> stripAudio(std::span<const float> audio,
                                   uint32_t croppingSteps = 10,
                                   float silenceThreshold = 0.005F);
 
-} // namespace rnexecutorch::models::text_to_speech::utils
+} // namespace rnexecutorch::models::text_to_speech::utils

packages/react-native-executorch/common/rnexecutorch/models/text_to_speech/kokoro/Constants.h

@@ -67,4 +67,4 @@ inline const std::unordered_map<char32_t, Token> kVocab = {
 inline constexpr Token kInvalidToken = -1;
 inline constexpr Token kPadToken = 0;
 
-} // namespace rnexecutorch::models::text_to_speech::kokoro::constants
+} // namespace rnexecutorch::models::text_to_speech::kokoro::constants

packages/react-native-executorch/common/rnexecutorch/models/text_to_speech/kokoro/Utils.cpp

@@ -43,4 +43,4 @@ std::vector<Token> tokenize(std::u32string_view phonemes,
   return tokens;
 }
 
-} // namespace rnexecutorch::models::text_to_speech::kokoro::utils
+} // namespace rnexecutorch::models::text_to_speech::kokoro::utils

packages/react-native-executorch/common/rnexecutorch/models/text_to_speech/kokoro/Utils.h

@@ -16,4 +16,4 @@ namespace rnexecutorch::models::text_to_speech::kokoro::utils {
 std::vector<Token> tokenize(std::u32string_view phonemes,
                             std::optional<size_t> expectedSize = std::nullopt);
 
-} // namespace rnexecutorch::models::text_to_speech::kokoro::utils
+} // namespace rnexecutorch::models::text_to_speech::kokoro::utils