Skip to content

Commit b794a54

Browse files
committed
Add comments
1 parent fdebc59 commit b794a54

File tree

3 files changed

+12
-5
lines changed

3 files changed

+12
-5
lines changed

android/src/main/java/com/swmansion/rnscreens/ScreenStackHeaderConfigViewManager.kt

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -164,11 +164,6 @@ class ScreenStackHeaderConfigViewManager :
164164
logNotAvailable("topInsetEnabled")
165165
}
166166

167-
override fun setUnstable_synchronousUpdatesEnabled(
168-
view: ScreenStackHeaderConfig?,
169-
value: Boolean,
170-
) = Unit
171-
172167
@ReactProp(name = "color", customType = "Color")
173168
override fun setColor(
174169
config: ScreenStackHeaderConfig,
@@ -209,6 +204,13 @@ class ScreenStackHeaderConfigViewManager :
209204
config.setDirection(direction)
210205
}
211206

207+
// unstable_synchronousUpdatesEnabled is not available on Android atm,
208+
// however we must override their setters
209+
override fun setUnstable_synchronousUpdatesEnabled(
210+
config: ScreenStackHeaderConfig?,
211+
value: Boolean,
212+
) = Unit
213+
212214
override fun getExportedCustomDirectEventTypeConstants(): Map<String, Any> =
213215
hashMapOf(
214216
HeaderAttachedEvent.EVENT_NAME to hashMapOf("registrationName" to "onAttached"),

android/src/main/java/com/swmansion/rnscreens/ScreenStackHeaderSubviewManager.kt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,8 @@ class ScreenStackHeaderSubviewManager :
4141
}
4242
}
4343

44+
// unstable_synchronousUpdatesEnabled is not available on Android atm,
45+
// however we must override their setters
4446
override fun setUnstable_synchronousUpdatesEnabled(
4547
view: ScreenStackHeaderSubview?,
4648
value: Boolean

android/src/main/java/com/swmansion/rnscreens/ScreenViewManager.kt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -268,6 +268,7 @@ open class ScreenViewManager :
268268
view?.sheetElevation = value.toFloat()
269269
}
270270

271+
// mark: iOS-only
271272
// these props are not available on Android, however we must override their setters
272273
override fun setFullScreenSwipeEnabled(
273274
view: Screen?,
@@ -339,6 +340,8 @@ open class ScreenViewManager :
339340
value: Boolean
340341
) = Unit
341342

343+
// END mark: iOS-only
344+
342345
@ReactProp(name = "sheetAllowedDetents")
343346
override fun setSheetAllowedDetents(
344347
view: Screen,

0 commit comments

Comments
 (0)