Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add otel4s integration #2432

Open
iRevive opened this issue Feb 3, 2025 · 1 comment · May be fixed by #2445
Open

Add otel4s integration #2432

iRevive opened this issue Feb 3, 2025 · 1 comment · May be fixed by #2445

Comments

@iRevive
Copy link

iRevive commented Feb 3, 2025 •
edited
Loading

https://github.com/typelevel/otel4s is the OpenTelemetry library for the Cats Effect ecosystem.

Besides opentelemetry-java integration, it also offers a Scala implementation of the OpenTelemetry specification, which is available for all platforms: JVM, Scala.js, and Scala Native.

Here is a prototype implementation: https://github.com/iRevive/otel4s-sttp:

The integration follows OpenTelemetry Semantic Conventions for spans and metrics:

It would be nice to have these integrations in the sttp repository. But there are a few questions:

  • otel4s hasn't released the 1.0 yet. Even though the otel4s-core module is stable, binary breaking changes occur occasionally. Does sttp require only stable versions (e.g. 1.0 onwards)?
  • should I provide integrations for client3 and client4?
@adamw
Copy link
Member

adamw commented Feb 3, 2025

sttp-client is fine with providing integrations for non-stable libraries. The binary compatibility guarantees are limited to sttp's core, as we simply can't take much responsibility for the libraries we integrate with (although we do our best, of course :) ).

Having an otel4s integration would be great. I would target client4, as there are some improvements relating to collecting metrics/traces, and we're very close to the final release :)

@iRevive iRevive linked a pull request Feb 11, 2025 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add otel4s OpenTelemetry backend iRevive/sttp
2 participants
@adamw @iRevive