Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logic error in error handling for MMSeqs2 server connection #663

Open
tristanic opened this issue Nov 18, 2024 · 1 comment
Open

Logic error in error handling for MMSeqs2 server connection #663

tristanic opened this issue Nov 18, 2024 · 1 comment

Comments

@tristanic
Copy link

Hasn't actually affected me, but noticed while reading the code: in the submit() and status() methods defined in run_mmseqs2(), I believe the error_count=0 lines

error_count = 0
and
error_count = 0
should be outside their respective while loops.

@milot-mirdita
Copy link
Collaborator

Looks like a real bug. Could you please submit a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants