refactor(deps): source BN from anchor and drop unused @types/bn.js (#688)

* refactor(deps): source BN from anchor and drop unused @types/bn.js

Tests imported BN directly from bn.js while declaring only @types/bn.js,
resolving the runtime package transitively. @anchor-lang/core re-exports
BN and depends on bn.js itself, so these tests can take BN from the
Anchor namespace they already import instead.

- Rewrite 17 test files from a direct bn.js import to anchor.BN
- Drop the now-dead direct bn.js dependency from two packages
- Remove @types/bn.js from 16 packages with no BN in their type surface
- Regenerate the affected per-project lockfiles

@types/bn.js is kept wherever BN is reachable. bn.js ships no type
declarations, so it is the only supplier of the BN type that Anchor maps
u64/i64/u128/i128 IDL fields to; removing it there widens those fields to
any instead of failing, because every tsconfig sets skipLibCheck.

* refactor(tokens): decode token accounts with kit codecs

Three litesvm tests decoded SPL token accounts with AccountLayout from
@solana/spl-token. The official program clients expose a decoder for this,
so use getTokenDecoder() from @solana-program/token, or token-2022 for the
Token-2022 example. amount is a bigint from both, so assertions are
unchanged. @solana/spl-token stays: all three still use its instruction
builders.

Also drops the unused ethers dependency from external-delegate-token-master.

The token clients are pinned to 0.15.0 rather than the 0.14.x used
elsewhere in the repo, because 0.14.x imports
getMinimumBalanceForRentExemption from @solana/kit, an export kit removed
in 7.1.0.

* refactor: remove dead dependencies and the last direct bn.js import

Removes dependencies with no importer in their package:

- nft-operations/anchor: @metaplex-foundation/mpl-token-metadata,
  @metaplex-foundation/umi, axios, node-fetch
- cnft-burn/anchor: @metaplex-foundation/umi
- cutils/anchor: @metaplex-foundation/js
- nft-meta-data-pointer/{anchor,app}: @coral-xyz/spl-token,
  browserify-sign, crypto-js, @chakra-ui/next-js

@metaplex-foundation/js is kept in cnft-burn, which does import it, and
Chakra's emotion and framer-motion peers are kept because Chakra needs
them. browserify-sign and crypto-js were version-floor pins rather than
real dependencies: crypto-js still resolves to 4.2.0 transitively, and
nothing in the tree depends on browserify-sign at all.

Also replaces the repository's last direct bn.js import, in cnft-burn's
ReadApi wrapper, where new BN(leaf_id).toArray('le', 8) becomes
getU64Encoder().encode(BigInt(leaf_id)).

* refactor(escrow): replace borsh helper with kit struct codecs

Both escrow examples wrapped a local borshSerialize(schema, data) helper
to build instruction data and to decode the Offer account. Replaces it
with getStructEncoder and getStructDecoder, matching the shape already
used in basics/close-account/native, and drops the borsh dependency.

Field widths and order were checked against each program's Rust source.
The decoder's fixed size of 113 matches Offer::LEN, and decoding the
pubkey fields with getAddressDecoder yields Address values directly, so
the tests no longer round-trip them through a raw byte array.

* refactor(basics,tokens): encode native instruction data with kit codecs

The remaining native and pinocchio examples hand-rolled borsh schemas
inline in their tests to build instruction data and decode their own
program accounts. Each example now exposes a ts/ client module built on
@solana/kit codecs, following basics/close-account/native: instruction
encoders and builders under ts/instructions, account decoders under
ts/state, and a discriminant map matching the program's instruction enum.
Tests import the builders instead of serializing by hand, and borsh is
removed from all twelve packages.

Encodings were checked field by field against each program's Rust source.
Where a program has no instruction discriminant, as in account-data,
processing-instructions and repository-layout, the encoder covers the bare
payload rather than inventing a tag.

Covers the last of the packages carrying borsh, so the repository no
longer depends on it anywhere.

Author: amilz

basics/account-data/anchor/package.json

@@ -4,7 +4,6 @@
     "@solana/web3.js": "^1.98.4"
   },
   "devDependencies": {
-    "@types/bn.js": "^5.1.0",
     "@types/chai": "^5.2.3",
     "@types/mocha": "^10.0.10",
     "chai": "^6.2.2",

basics/account-data/anchor/pnpm-lock.yaml

@@ -8,8 +8,7 @@
   },
   "dependencies": {
     "@solana/kit": "^7.0.0",
-    "@solana-program/system": "^0.13.0",
-    "borsh": "^2.0.0"
+    "@solana-program/system": "^0.13.0"
   },
   "devDependencies": {
     "@types/chai": "^5.2.3",

basics/account-data/native/package.json

@@ -1,6 +1,4 @@
-import { Buffer } from 'node:buffer';
 import {
-    AccountRole,
     type Address,
     appendTransactionMessageInstruction,
     createTransactionMessage,
@@ -11,33 +9,18 @@ import {
     setTransactionMessageFeePayerSigner,
     signTransactionMessageWithSigners,
 } from '@solana/kit';
-import { SYSTEM_PROGRAM_ADDRESS } from '@solana-program/system';
-import * as borsh from 'borsh';
 import { assert } from 'chai';
 import { FailedTransactionMetadata, LiteSVM } from 'litesvm';
-
-const AddressInfoSchema = {
-    struct: {
-        name: 'string',
-        house_number: 'u8',
-        street: 'string',
-        city: 'string',
-    },
-};
-
-type AddressInfo = {
-    name: string;
-    house_number: number;
-    street: string;
-    city: string;
-};
-
-function borshSerialize(schema: borsh.Schema, data: object): Buffer {
-    return Buffer.from(borsh.serialize(schema, data));
-}
+import { type AddressInfo, addressInfoDecoder, createCreateAddressInfoInstruction } from '../ts';
 
 describe('Account Data!', () => {
     const svm = new LiteSVM();
+    const addressInfo: AddressInfo = {
+        name: 'Joe C',
+        houseNumber: 136,
+        street: 'Mile High Dr.',
+        city: 'Solana Beach',
+    };
     let programId: Address;
     let payer: KeyPairSigner;
     let addressInfoAccount: KeyPairSigner;
@@ -51,30 +34,7 @@ describe('Account Data!', () => {
     });
 
     it('Create the address info account', async () => {
-        console.log(`Program Address      : ${programId}`);
-        console.log(`Payer Address      : ${payer.address}`);
-        console.log(`Address Info Acct  : ${addressInfoAccount.address}`);
-
-        const ix = {
-            programAddress: programId,
-            accounts: [
-                {
-                    address: addressInfoAccount.address,
-                    role: AccountRole.WRITABLE_SIGNER,
-                    signer: addressInfoAccount,
-                },
-                { address: payer.address, role: AccountRole.WRITABLE_SIGNER, signer: payer },
-                { address: SYSTEM_PROGRAM_ADDRESS, role: AccountRole.READONLY },
-            ],
-            data: new Uint8Array(
-                borshSerialize(AddressInfoSchema, {
-                    name: 'Joe C',
-                    house_number: 136,
-                    street: 'Mile High Dr.',
-                    city: 'Solana Beach',
-                }),
-            ),
-        };
+        const ix = createCreateAddressInfoInstruction(addressInfoAccount, payer, programId, addressInfo);
 
         const transactionMessage = pipe(
             createTransactionMessage({ version: 0 }),
@@ -92,10 +52,6 @@ describe('Account Data!', () => {
         const accountInfo = svm.getAccount(addressInfoAccount.address);
         assert(accountInfo.exists, 'address info account not found');
 
-        const readAddressInfo = borsh.deserialize(AddressInfoSchema, Buffer.from(accountInfo.data)) as AddressInfo;
-        console.log(`Name     : ${readAddressInfo.name}`);
-        console.log(`House Num: ${readAddressInfo.house_number}`);
-        console.log(`Street   : ${readAddressInfo.street}`);
-        console.log(`City     : ${readAddressInfo.city}`);
+        assert.deepEqual(addressInfoDecoder.decode(accountInfo.data), addressInfo);
     });
 });

basics/account-data/native/pnpm-lock.yaml

@@ -0,0 +1,2 @@
+export * from './instructions';
+export * from './state';

basics/account-data/native/tests/test.ts

@@ -0,0 +1,41 @@
+import {
+    AccountRole,
+    addEncoderSizePrefix,
+    type Address,
+    getStructEncoder,
+    getU8Encoder,
+    getU32Encoder,
+    getUtf8Encoder,
+    type TransactionSigner,
+} from '@solana/kit';
+import { SYSTEM_PROGRAM_ADDRESS } from '@solana-program/system';
+import type { AddressInfo } from '../state';
+
+// Instruction data layout: the program deserializes the whole payload as an `AddressInfo`.
+export const createAddressInfoEncoder = getStructEncoder([
+    ['name', addEncoderSizePrefix(getUtf8Encoder(), getU32Encoder())],
+    ['houseNumber', getU8Encoder()],
+    ['street', addEncoderSizePrefix(getUtf8Encoder(), getU32Encoder())],
+    ['city', addEncoderSizePrefix(getUtf8Encoder(), getU32Encoder())],
+]);
+
+export function createCreateAddressInfoInstruction(
+    addressInfoAccount: TransactionSigner,
+    payer: TransactionSigner,
+    programId: Address,
+    addressInfo: AddressInfo,
+) {
+    return {
+        programAddress: programId,
+        accounts: [
+            {
+                address: addressInfoAccount.address,
+                role: AccountRole.WRITABLE_SIGNER,
+                signer: addressInfoAccount,
+            },
+            { address: payer.address, role: AccountRole.WRITABLE_SIGNER, signer: payer },
+            { address: SYSTEM_PROGRAM_ADDRESS, role: AccountRole.READONLY },
+        ],
+        data: createAddressInfoEncoder.encode(addressInfo),
+    };
+}

basics/account-data/native/ts/index.ts

@@ -0,0 +1 @@
+export * from './create';

basics/account-data/native/ts/instructions/create.ts

@@ -0,0 +1,16 @@
+import { addDecoderSizePrefix, getStructDecoder, getU8Decoder, getU32Decoder, getUtf8Decoder } from '@solana/kit';
+
+export type AddressInfo = {
+    name: string;
+    houseNumber: number;
+    street: string;
+    city: string;
+};
+
+// Account data layout, matching the program's `AddressInfo` struct.
+export const addressInfoDecoder = getStructDecoder([
+    ['name', addDecoderSizePrefix(getUtf8Decoder(), getU32Decoder())],
+    ['houseNumber', getU8Decoder()],
+    ['street', addDecoderSizePrefix(getUtf8Decoder(), getU32Decoder())],
+    ['city', addDecoderSizePrefix(getUtf8Decoder(), getU32Decoder())],
+]);

basics/account-data/native/ts/instructions/index.ts

@@ -10,7 +10,6 @@
     "@solana/web3.js": "^1.98.4"
   },
   "devDependencies": {
-    "@types/bn.js": "^5.1.0",
     "@types/chai": "^5.2.3",
     "@types/mocha": "^10.0.10",
     "anchor-litesvm": "^0.2.1",