Skip to content

Comments

fix: web CI 타입 경로 충돌 해결#429

Merged
manNomi merged 2 commits intomainfrom
fix/web-ts-ci-error-from-main
Feb 14, 2026
Merged

fix: web CI 타입 경로 충돌 해결#429
manNomi merged 2 commits intomainfrom
fix/web-ts-ci-error-from-main

Conversation

@manNomi
Copy link
Contributor

@manNomi manNomi commented Feb 14, 2026

Summary

  • apps/web/tsconfig.ci.jsontypeRoots에서 워크스페이스 루트 경로(../../node_modules/@types)를 제거했습니다.
  • web CI 타입체크가 web 패키지의 로컬 타입(./node_modules/@types)만 사용하도록 고정해 React 타입 버전 혼재로 인한 JSX 타입 오류를 방지했습니다.

Verification

  • pnpm --filter @solid-connect/web run ci:check
  • pnpm --filter @solid-connect/web run build
  • pre-push CI parity build 통과

@vercel
Copy link

vercel bot commented Feb 14, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
solid-connection-web Error Error Feb 14, 2026 1:34pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
solid-connect-web-admin Skipped Skipped Feb 14, 2026 1:34pm

@coderabbitai
Copy link

coderabbitai bot commented Feb 14, 2026

Warning

Rate limit exceeded

@manNomi has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 15 minutes and 13 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Walkthrough

타입스크립트 설정 파일인 tsconfig.ci.json에서 타입 해석 경로를 조정했습니다.

  1. 타입 루트 경로 변경
    • ../../node_modules/@types에서 ./node_modules/@types로 수정
    • 타입 해석을 상위 디렉토리가 아닌 로컬 node_modules로만 제한하도록 변경

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 분

Suggested reviewers

  • wibaek
  • enunsnv
  • khwww
🚥 Pre-merge checks | ✅ 3 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Merge Conflict Detection ⚠️ Warning ❌ Merge conflicts detected (19 files):

⚔️ .github/workflows/ci.yml (content)
⚔️ apps/admin/package.json (content)
⚔️ apps/admin/src/components/features/scores/GpaScoreTable.tsx (content)
⚔️ apps/admin/src/components/features/scores/LanguageScoreTable.tsx (content)
⚔️ apps/admin/src/components/features/scores/ScoreVerifyButton.tsx (content)
⚔️ apps/admin/src/components/features/scores/StatusBadge.tsx (content)
⚔️ apps/admin/src/components/layout/AdminLayout.tsx (content)
⚔️ apps/admin/src/components/ui/button.tsx (content)
⚔️ apps/admin/src/components/ui/input.tsx (content)
⚔️ apps/admin/src/components/ui/table.tsx (content)
⚔️ apps/admin/src/components/ui/tabs.tsx (content)
⚔️ apps/admin/src/routes/scores/index.tsx (content)
⚔️ apps/admin/src/styles.css (content)
⚔️ apps/admin/vite.config.ts (content)
⚔️ apps/web/src/components/layout/RootModal/index.tsx (content)
⚔️ apps/web/src/components/layout/RootModal/ui/ClientModal/index.tsx (content)
⚔️ apps/web/src/components/mentor/MentorApplyCountContent/index.tsx (content)
⚔️ apps/web/src/components/mentor/MentorExpandChatCard/hooks/useExpandCardClickHandler.ts (content)
⚔️ apps/web/src/lib/zustand/useAuthStore.ts (content)

These conflicts must be resolved before merging into main.
Resolve conflicts locally and push changes to this branch.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed PR 제목은 변경사항의 핵심(web CI의 타입 경로 충돌 해결)을 명확하게 설명하고 있습니다.
Description check ✅ Passed PR 설명은 요구 템플릿의 주요 섹션(작업 내용, 검증)을 포함하고 있으나, '관련 이슈' 섹션이 누락되어 있습니다.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/web-ts-ci-error-from-main

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@vercel
Copy link

vercel bot commented Feb 14, 2026

Deployment failed with the following error:

Resource is limited - try again in 19 hours (more than 100, code: "api-deployments-free-per-day").

Learn More: https://vercel.com/mannomis-projects?upgradeToPro=build-rate-limit

@manNomi manNomi merged commit aadb33e into main Feb 14, 2026
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant