Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation bot: sync PRs for tagged releases #22

Open
cameel opened this issue Jul 5, 2022 · 1 comment · May be fixed by #53
Open

Translation bot: sync PRs for tagged releases #22

cameel opened this issue Jul 5, 2022 · 1 comment · May be fixed by #53
Assignees
Labels
enhancement New feature or request

Comments

@cameel
Copy link
Collaborator

cameel commented Jul 5, 2022

Some translator teams are targeting specific tagged versions of the compiler (for example the Turkish team wants to translate and tag 0.8.15 before moving on to translating any further changes). In this use case the team is not interested in receiving PRs each time something changes in the main repo but will still be interested in a PR covering all the changes since the last release once a new one is tagged.

And overall, even if the team is fully caught up and translating all incoming changes, getting a specific version translated can be a problem if we set the PR interval to multiple days (and we might want to do that if it turns out that daily is too often). For example if we set it to a PR per week, and a compiler release happens in the middle of the week, there will be no PR containing only changes up to the release. There will be one covering the whole week, possibly containing bits from both versions.

For this reason the bot should:

  • Check if a new release has been tagged and if so, issue an additional tag PR that includes only changes from that version. It should still issue a normal periodic PR too.
  • We should be able to choose for specific repos to only enable the tag PRs and disable the periodic ones.
@cameel cameel added the enhancement New feature or request label Jul 5, 2022
@cameel cameel self-assigned this Jul 5, 2022
@cameel cameel changed the title Translation bot: PR for each tagged release Translation bot: sync PRs for tagged releases Dec 16, 2022
@cameel
Copy link
Collaborator Author

cameel commented Dec 16, 2022

I think that we could solve it even better. Instead of creating sync PRs for tags and daily sync PRs at the same time, the bot should keep creating sync PRs only for the next tag and switch to daily PRs for develop only when all tags are translated.

So, say a team starts its translation by cloning the upstream repo somewhere between 0.8.13 and 0.8.14 while the current version is 0.8.17:

  • Initially the bot should create a single sync PR for 0.8.14. If it's closed without merging the bot should recreate it but not create any other PRs.
  • Once the sync PR is merged the history will include 0.8.14 from the Solidity repo. Bot should see that and create a sync PR for 0.8.15.
  • When 0.8.17 is translated, bot should switch to creating daily sync PRs to sync with develop.

This would also have a nice effect of reducing the daily spam of sync PRs for teams that have not caught up and are ignoring them anyway.

@cameel cameel assigned r0qs and unassigned cameel Dec 16, 2022
@r0qs r0qs linked a pull request Feb 6, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants