Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

createScriptLoader causes rootless resource error #646

Open
apatrida opened this issue Jun 19, 2024 · 1 comment
Open

createScriptLoader causes rootless resource error #646

apatrida opened this issue Jun 19, 2024 · 1 comment

Comments

@apatrida
Copy link

Describe the bug

In createScriptLoader the following code:

 setTimeout(() => spread(script, scriptProps, false, true));

causes a warning about doing reactive things outside a root not disposing of resources. Changing to:

 setTimeout(createCallback(() => spread(script, scriptProps, false, true)));

removes the warning.

Minimal Reproduction Link

not-required

@atk
Copy link
Member

atk commented Jun 19, 2024

We specifically added the timeout to move the call of spread out of the context, as otherwise hydration breaks. Can you please test your fix in a solid-start app with SSG+hydration?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants