Proposal: use a key prop to override Meta tags
#39
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this changes
<Meta>tags are not replaced by default.<Meta>tags are considered to be the same and overridden if thekey(string) prop matches.That's it.
<Title>is still always replaced.Why
Why not userland
<Title>, so userland de-duplication of meta tags would essentially add the same logic.Status
Work in progress, need to figure out the tests but the basic implementation is done. Also, I think the
keyprop will currently be set as an attribute, so probably need to exclude it before rendering. Couldn't test yet because of local env issues.Open questions
keyan appropriate/descriptive prop name for this?Related
#34 #40