diff --git a/app/models/spree/tracker.rb b/app/models/spree/tracker.rb
index a1b8420..837f4ef 100644
--- a/app/models/spree/tracker.rb
+++ b/app/models/spree/tracker.rb
@@ -6,7 +6,7 @@ class Spree::Tracker < ActiveRecord::Base
def self.current(store = nil)
return if !store
if store.is_a?(Spree::Store)
- Spree::Tracker.where(active: true, store_id: store)
+ Spree::Tracker.where(active: true, store_id: store).first
else
# TODO: Remove in 2.0
ActiveSupport::Deprecation.warn <<-EOS.squish, caller
@@ -16,24 +16,18 @@ def self.current(store = nil)
Spree::Tracker.where(active: true).joins(:store).where(
"spree_stores.code = ? OR spree_stores.url LIKE ?",
store, "%#{store}%"
- )
+ ).first
end
end
+ class << self
+ deprecate current_tracker: :current, deprecator: Spree::Deprecation
+ end
- def self.by_type(store = nil, type = nil)
+ def self.by_type(store: Spree::Store.default, type: 'google_analytics')
return if !store
- if store.is_a?(Spree::Store)
- Spree::Tracker.where(active: true, store_id: store, tracker_type: type).first
- else
- # TODO: Remove in 2.0
- ActiveSupport::Deprecation.warn <<-EOS.squish, caller
- Calling Spree::Tracker.by_type with a string is DEPRECATED. Instead
- pass it an instance of Spree::Store.
- EOS
- Spree::Tracker.where(active: true, tracker_type: type).joins(:store).where(
- "spree_stores.code = ? OR spree_stores.url LIKE ?",
- store, "%#{store}%"
- ).first
- end
+
+ Spree::Tracker.where(active: true,
+ store_id: store,
+ tracker_type: type).first
end
end
diff --git a/app/views/spree/admin/trackers/_form.html.erb b/app/views/spree/admin/trackers/_form.html.erb
index bf4d017..dc546b9 100644
--- a/app/views/spree/admin/trackers/_form.html.erb
+++ b/app/views/spree/admin/trackers/_form.html.erb
@@ -20,11 +20,11 @@
-
<%= radio_button(:tracker, :active, true) %>
- <%= label_tag :tracker_active_true, Spree.t(:say_yes) %>
+ <%= label_tag :tracker_active_true, t('spree.say_yes') %>
-
<%= radio_button(:tracker, :active, false) %>
- <%= label_tag :tracker_active_false, Spree.t(:say_no) %>
+ <%= label_tag :tracker_active_false, t('Spree.say_no') %>
diff --git a/app/views/spree/admin/trackers/index.html.erb b/app/views/spree/admin/trackers/index.html.erb
index d1d6a6d..cddd553 100644
--- a/app/views/spree/admin/trackers/index.html.erb
+++ b/app/views/spree/admin/trackers/index.html.erb
@@ -1,43 +1,50 @@
-<%= render 'spree/admin/shared/general_tabs' %>
+<%= render "spree/admin/shared/general_tabs" %>
-<% admin_breadcrumb(Spree.t(:settings)) %>
-<% admin_breadcrumb(Spree.t(:general_settings)) %>
+<% admin_breadcrumb(t("spree.settings")) %>
+<% admin_breadcrumb(t("spree.general_settings")) %>
<% admin_breadcrumb(plural_resource_name(Spree::Tracker)) %>
<% content_for :page_actions do %>
<% if can?(:create, Spree::Tracker) %>
- <%= link_to Spree.t(:new_tracker), new_object_url, id: 'admin_new_tracker_link', class: 'btn btn-primary' %>
+ <%= link_to t("spree.new_tracker"),
+ new_object_url,
+ :id => "admin_new_tracker_link",
+ :class => "btn btn-primary" %>
<% end %>
<% end %>
<% if @trackers.any? %>
-
+
-
-
-
-
-
+
+
+
+
+
-
+
<%= Spree::Tracker.human_attribute_name(:analytics_id) %> |
<%= Spree::Tracker.human_attribute_name(:tracker_type) %> |
- <%= Spree::Tracker.human_attribute_name(:active) %> |
- <%= Spree.t(:store) %> |
+ <%= t("spree.status") %> |
+ <%= t("spree.store") %> |
|
<% @trackers.each do |tracker|%>
- '>
+
">
<%= tracker.analytics_id %> |
<%= display_tracker_type(tracker) %> |
- <%= tracker.active ? Spree.t(:say_yes) : Spree.t(:say_no) %> |
+
+
+ <%= t(tracker.active? ? :active : :inactive, scope: 'spree') %>
+
+ |
<%= tracker.store.try(:name) %> |
<% if can?(:update, tracker) %>
@@ -53,8 +60,8 @@
|
<% else %>
-
- <%= render 'spree/admin/shared/no_objects_found',
+
+ <%= render "spree/admin/shared/no_objects_found",
resource: Spree::Tracker,
new_resource_url: new_object_url %>
diff --git a/app/views/spree/admin/trackers/new.html.erb b/app/views/spree/admin/trackers/new.html.erb
index 53febaa..770c6c8 100644
--- a/app/views/spree/admin/trackers/new.html.erb
+++ b/app/views/spree/admin/trackers/new.html.erb
@@ -1,7 +1,7 @@
<%= render 'spree/admin/shared/general_tabs' %>
<% admin_breadcrumb(link_to plural_resource_name(Spree::Tracker), spree.admin_trackers_path) %>
-<% admin_breadcrumb(Spree.t(:new_tracker)) %>
+<% admin_breadcrumb(t("spree.new_tracker")) %>
<% content_for :page_actions do %>
<% end %>
diff --git a/app/views/spree/shared/_google_analytics.html.erb b/app/views/spree/shared/_google_analytics.html.erb
index 0e1833e..c2e9934 100644
--- a/app/views/spree/shared/_google_analytics.html.erb
+++ b/app/views/spree/shared/_google_analytics.html.erb
@@ -1,4 +1,4 @@
-<% tracker = Spree::Tracker.by_type(Spree::Store.default, 'google_analytics') %>
+<% tracker = Spree::Tracker.by_type(store: Spree::Store.default, type: 'google_analytics') %>
<% if tracker %>