Adding a new type of user address

[zernie]

Currently, there are two types of user addresses: billing and shipping. For my marketplace (where users can own products) I'd like to add a new type, called product. However, it is hard to customize the logic because:

1. Spree::UserAddressBook#save_in_address_book needs to be overriden
   1.1 In here
   

   solidus/core/app/models/concerns/spree/user_address_book.rb

   Lines 122 to 126 in e878076

   	user_addresses.reset
   	association(:default_user_ship_address).reset
   	association(:ship_address).reset
   	association(:default_user_bill_address).reset
   	association(:bill_address).reset

   
   1.2. and in here
   

   solidus/core/app/models/concerns/spree/user_address_book.rb

   Line 113 in e878076

   user_addresses.mark_default(user_address, address_type: address_type) if default || first_one

   
   the problem with this line is that user_addresses.mark_default is defined only on user_addresses association:
   

   solidus/core/app/models/concerns/spree/user_address_book.rb

   Lines 8 to 14 in e878076

   	has_many :user_addresses, -> { active }, foreign_key: "user_id", class_name: "Spree::UserAddress" do
   	def find_first_by_address_values(address_attrs)
   	detect { |ua| ua.address == Spree::Address.new(address_attrs) }
   	end
   	def mark_default(user_address, address_type: :shipping)
   	column_for_default = address_type == :shipping ? :default : :default_billing

   
   not on Spree::UserAddress, so you'd need to add a new custom method
2. Spree::UserAddressBook#product_address= needs to be added manually
3. Spree::UserAddressBook#product_address_attributes= needs to be added manually

4. solidus/core/app/models/concerns/spree/user_address_book.rb

   Lines 160 to 164 in e878076

   	def remove_user_address_reference(address_id)
   	self.bill_address_id = bill_address_id == address_id.to_i ? nil : bill_address_id
   	self.ship_address_id = ship_address_id == address_id.to_i ? nil : ship_address_id
   	save if changed?
   	end

   needs to overriden

5. solidus/core/app/models/concerns/spree/user_address_book.rb

   Lines 72 to 91 in e878076

   	def persist_order_address(order)
   	if order.ship_address
   	address = save_in_address_book(
   	order.ship_address.attributes,
   	Spree::Config.automatic_default_address
   	)
   	self.ship_address_id = address.id if address&.persisted?
   	end
   	if order.bill_address
   	address = save_in_address_book(
   	order.bill_address.attributes,
   	Spree::Config.automatic_default_address,
   	:billing
   	)
   	self.bill_address_id = address.id if address&.persisted?
   	end
   	save! # In case the ship_address_id or bill_address_id was set
   	end

   
   needs to overriden
   I might be missing something. But the point is: Could the logic of adding a new kind of address be generalized?

[jarednorman]

That's an interesting situation. I don't think I've ever seen one add more kinds of addresses like that.

[zernie]

@jarednorman haha. But do you think that I'm doing it correctly or should I take a different approach?

[jarednorman]

You've covered most of the main stuff I could think of. I think augmenting the address book system like this is the way to go, I'm just not sure this is a very common use case.

[kennyadsl]

Bill and Ship Addresses seem to have a lot of things in common. I'd be happy to review a PR where we try to generalize this concept, especially if this can be useful to create more address types as in your scenario.