Skip to content

Conversation

@tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Nov 20, 2025

Summary

Currently we always enqueues a ActiveJob, but some stores maybe want to inline the state changes or add more information to the state change record. This allows to set your own state change tracker class. It defaults to the current behavior.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@tvdeyen tvdeyen requested a review from a team as a code owner November 20, 2025 17:44
@tvdeyen tvdeyen added the backport-v4.6 Backport this pull-request to v4.6 label Nov 20, 2025
@github-actions github-actions bot added the changelog:solidus_core Changes to the solidus_core gem label Nov 20, 2025
@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.46%. Comparing base (d3ef74b) to head (3cf18bb).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6375   +/-   ##
=======================================
  Coverage   89.46%   89.46%           
=======================================
  Files         975      976    +1     
  Lines       20335    20340    +5     
=======================================
+ Hits        18192    18197    +5     
  Misses       2143     2143           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tvdeyen tvdeyen force-pushed the config-state-change-job-class branch from 7840384 to 578b60e Compare November 21, 2025 14:48
Currently we always enqueues a ActiveJob, but some stores
maybe want to inline the state changes or add more information
to the state change record. This allows to set your own state
change tracker class. It defaults to the current behavior.
@tvdeyen tvdeyen force-pushed the config-state-change-job-class branch from 578b60e to 3cf18bb Compare November 26, 2025 07:32
@tvdeyen tvdeyen enabled auto-merge November 26, 2025 07:33
@tvdeyen tvdeyen merged commit 6890f58 into solidusio:main Nov 26, 2025
38 of 39 checks passed
@tvdeyen tvdeyen deleted the config-state-change-job-class branch November 26, 2025 07:43
@solidus-bot
Copy link

solidus-bot bot commented Nov 26, 2025

💚 All backports created successfully

Status Branch Result
v4.6

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-v4.6 Backport this pull-request to v4.6 changelog:solidus_core Changes to the solidus_core gem

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants