Skip to content

Commit d24d34e

Browse files
authored
Merge pull request #237 from SuperGoodSoft/alistair/update-rspec-rails
Update rspec-rails versions and fix tests
2 parents 721f64c + 4ae946a commit d24d34e

File tree

3 files changed

+2
-3
lines changed

3 files changed

+2
-3
lines changed

lib/solidus_dev_support/templates/extension/bin/sandbox.tt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ rm -rf ./sandbox
3131

3232
echo "~~~> Creating a pristine Rails app"
3333
rails_version=`bundle exec ruby -e'require "rails"; puts Rails.version'`
34-
rails _${rails_version}_ new sandbox \
34+
unbundled bundle exec rails _${rails_version}_ new sandbox \
3535
--database="${DB:-sqlite3}" \
3636
--skip-git \
3737
--skip-keeps \

solidus_dev_support.gemspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ Gem::Specification.new do |spec|
3939
spec.add_dependency "github_changelog_generator", "~> 1.15"
4040
spec.add_dependency "puma", ">= 4.3", "< 7.0"
4141
spec.add_dependency "rspec_junit_formatter"
42-
spec.add_dependency "rspec-rails", ">= 5.0", "< 7.0"
42+
spec.add_dependency "rspec-rails", ">= 6.0", "< 9.0"
4343
spec.add_dependency "selenium-webdriver", "~> 4.11"
4444
spec.add_dependency "simplecov-cobertura", "~> 2.1"
4545
spec.add_dependency "solidus_core", [">= 2.0", "< 5"]

spec/features/create_extension_spec.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,6 @@ def check_bundle_install
114114
def check_default_task
115115
cd(install_path) do
116116
output = sh("bin/rake")
117-
expect(output).to include("Generating dummy Rails application")
118117
expect(output).to include("0 examples, 0 failures")
119118
end
120119
end

0 commit comments

Comments
 (0)