Skip to content

Commit 80e2cd5

Browse files
authored
fix filter bug + test (#72)
* fix filter bug + test
1 parent 3ed619a commit 80e2cd5

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

source/extensions/filters/http/aws_lambda/aws_lambda_filter.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ AWSLambdaFilter::decodeHeaders(Http::RequestHeaderMap &headers,
8383
secret_key = &protocol_options_->secretKey().value();
8484
// attempt to set session_token, ok if nil
8585
if (protocol_options_->sessionToken().has_value()) {
86-
session_token = &protocol_options_->secretKey().value();
86+
session_token = &protocol_options_->sessionToken().value();
8787
}
8888
} else if (filter_config_) {
8989
credentials_ = filter_config_->getCredentials();

test/extensions/filters/http/aws_lambda/aws_lambda_filter_test.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ TEST_F(AWSLambdaFilterTest, SignsOnHeadersEndStreamWithToken) {
131131

132132
// Check aws headers.
133133
EXPECT_TRUE(headers.has("Authorization"));
134-
EXPECT_TRUE(headers.has(AwsAuthenticatorConsts::get().SecurityTokenHeader));
134+
EXPECT_EQ(headers.get(AwsAuthenticatorConsts::get().SecurityTokenHeader)->value(), "session token");
135135
}
136136

137137
TEST_F(AWSLambdaFilterTest, SignsOnHeadersEndStreamWithConfig) {
@@ -160,7 +160,7 @@ TEST_F(AWSLambdaFilterTest, SignsOnHeadersEndStreamWithConfigWithToken) {
160160
EXPECT_TRUE(filter_config_->called_);
161161
// Check aws headers.
162162
EXPECT_TRUE(headers.has("Authorization"));
163-
EXPECT_TRUE(headers.has(AwsAuthenticatorConsts::get().SecurityTokenHeader));
163+
EXPECT_EQ(headers.get(AwsAuthenticatorConsts::get().SecurityTokenHeader)->value(), "session token");
164164
}
165165

166166
TEST_F(AWSLambdaFilterTest, SignsOnHeadersEndStreamWithBadConfig) {

0 commit comments

Comments
 (0)