Skip to content

ResourceFuncs usage was removed from rendering manifests #519

@inFocus7

Description

@inFocus7

Context

A previous update to support conditional CRD rendering removed our usage of ResourceFuncs. Previously while rendering we went through the ResourceFuncs functions to add to our manifest rendered, but now we don't have any logic doing so.

https://github.com/solo-io/skv2/pull/462/files#diff-813e5efb857f3e8d15508b847892b877943384a6e05532b633e99a5765d66a17L74-L81

Additional Notes

  • I'm unsure if this was intentional, but I didn't see any notes regarding it.
    • If it was intentional, should we just remove ResourceFuncs from the ManifestsRenderer object?
    • In addition, do we know/have workarounds to it?
  • manifests_renderer.go

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions