Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust the boundary to improve the plotting #335

Open
Gene0315 opened this issue May 28, 2024 · 6 comments
Open

Adjust the boundary to improve the plotting #335

Gene0315 opened this issue May 28, 2024 · 6 comments
Assignees
Labels
enhancement New feature or request onedim One-dimensional solver viewer Visualize stuff

Comments

@Gene0315
Copy link
Collaborator

PR #330 implemented new boundary treatment. However, apart from revising the NRBC method, it is also a nice way to make some other adjustments to improve the plotting.
For instance, add a half dx grid point outside the boundary and not show it on the figure.

@yungyuc
Copy link
Member

yungyuc commented May 29, 2024

@j8xixo12 This may be an opportunity to give the Euler 1D app a better architecture and absorb it into proper places in the GUI. What do you think?

@yungyuc yungyuc added viewer Visualize stuff onedim One-dimensional solver labels May 29, 2024
@j8xixo12
Copy link
Collaborator

@yungyuc Since modmesh has mesh viewer which is able to read Gmsh and Plot3d mesh file and a Euler 1D solver. I think it's time to re-design the GUI!

But currently I have no idea how to design the new GUI. If the GUI should be designed based on a numerical analysis workflow, where the user first loads the mesh, then sets up the solver configuration likes boundary condition and convergence criteria...etc and then runs the simulation, these steps are guided by GUI. Or should it be divided by functionality, with each button corresponding to a specific function. I think this design is similar to the current design of modmesh, but it seems like lacking in integration. the previous design more like... Ansys workbench!

@yungyuc yungyuc changed the title Adjust the boundary to imporve the plotting Adjust the boundary to improve the plotting May 31, 2024
@yungyuc
Copy link
Member

yungyuc commented May 31, 2024

@j8xixo12 I outlined some ideas in #336 . At this stage, the key is to organize what we had in the proof-of-concept "Apps", and make the "Apps" a clear plugin system.

I am not sure how Ansys workbench looks like, and certainly did not reference it. In my vision, the GUI will be an integrated problem-solving environment. We will need to give it a cool name once putting it back to the mother solvcon code base.

@yungyuc
Copy link
Member

yungyuc commented Jun 5, 2024

@Gene0315 plans to update #338 (comment) by 8th June. We will review then.

@yungyuc yungyuc added the enhancement New feature or request label Jun 9, 2024
@yungyuc
Copy link
Member

yungyuc commented Jul 14, 2024

@Gene0315 is there any progress made for this enhancement request?

@Gene0315
Copy link
Collaborator Author

@Gene0315 is there any progress made for this enhancement request?

I failed to add the variable which represents the grid index shown in the figure. I created a PR in my repo to try to add it successfully, but I’ve not solved it yet. I don't know how to get more detail error messages in the VSCODE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request onedim One-dimensional solver viewer Visualize stuff
Projects
Status: In Progress
Development

No branches or pull requests

3 participants