Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple sub-windows user experience enhancement #357

Open
j8xixo12 opened this issue Jun 8, 2024 · 20 comments
Open

Multiple sub-windows user experience enhancement #357

j8xixo12 opened this issue Jun 8, 2024 · 20 comments
Assignees
Labels
enhancement New feature or request viewer Visualize stuff

Comments

@j8xixo12
Copy link
Collaborator

j8xixo12 commented Jun 8, 2024

In #356 @yungyuc create a window button in menubar which will use for managing sub-windows.
If multiple sub-windows are opened in modmesh, they will overlap each other, which is a bad user experience.

The sub-windows management is needed, so create an issue to track it and discussion.

@tigercosmos
Copy link
Collaborator

@j8xixo12 any solution in mind?

@yungyuc yungyuc added the viewer Visualize stuff label Jun 8, 2024
@yungyuc
Copy link
Member

yungyuc commented Jun 8, 2024

@j8xixo12 any solution in mind?

@tigercosmos this is a straight-forward enhancement. It may be productive to discuss using PR.

@yungyuc
Copy link
Member

yungyuc commented Jun 9, 2024

@j8xixo12 Do we need this in the milestone number 1, whose goal is to "revamp GUI to provide access to one-dimensional solver and mesh viewing from the menu" (does not include sub-window management)?

@yungyuc yungyuc added the enhancement New feature or request label Jun 9, 2024
@j8xixo12
Copy link
Collaborator Author

I think we can put this to next milestone, as the milestone number 1 is focusing on one-dimensional solver and mesh viewing. Additionally I expect more user after this release, there will be more GUI issues.
We can solve the following issues together in next milestone.

@yungyuc
Copy link
Member

yungyuc commented Jun 10, 2024

Sounds good. Thanks @j8xixo12

@yungyuc
Copy link
Member

yungyuc commented Jun 28, 2024

This seems to be a useful feature. @j8xixo12 I am moving this to the todo list in https://github.com/orgs/solvcon/projects/8. We can discuss later whether it should go into the milestone 1.

@yungyuc
Copy link
Member

yungyuc commented Jun 28, 2024

@YenPeiChen07 Could you please help take a look at this one?

@YenPeiChen07
Copy link
Collaborator

@YenPeiChen07 Could you please help take a look at this one?

ok, I will take a look.

@j8xixo12
Copy link
Collaborator Author

j8xixo12 commented Jul 3, 2024

@j8xixo12 any solution in mind?

I have a idea, we can use tab to deal with opening multiple applications in the same time, the follwing is my revised version on figma:
image

I think the this layout can be used as application template for future application development, so the other developer will not need to take care about GUI code.

@yungyuc
Copy link
Member

yungyuc commented Jul 4, 2024

The tab is nice. I wonder what would be added for the "Windows" menu? I think the "Tabs" and "Windows" are orthogonal.

@j8xixo12
Copy link
Collaborator Author

j8xixo12 commented Jul 4, 2024

The tab is nice. I wonder what would be added for the "Windows" menu? I think the "Tabs" and "Windows" are orthogonal.

I think we can add maximum / minimum main windows size and tile the window to the left / right / top / down side of screen.

@yungyuc
Copy link
Member

yungyuc commented Jul 5, 2024

The tab is nice. I wonder what would be added for the "Windows" menu? I think the "Tabs" and "Windows" are orthogonal.

I think we can add maximum / minimum main windows size and tile the window to the left / right / top / down side of screen.

I think we are discussing the management of the sub-windows, not the main window? We can leave the main window for future work. Could please list again what should be added in the Windows menu for sub-windows?

@yungyuc
Copy link
Member

yungyuc commented Jul 6, 2024

@j8xixo12 @YenPeiChen07 could you please also reference how paraview, gmsh, and blender manage sub-windows?

@j8xixo12
Copy link
Collaborator Author

j8xixo12 commented Jul 8, 2024

@j8xixo12 @YenPeiChen07 could you please also reference how paraview, gmsh, and blender manage sub-windows?

I referred how the paraview, gmsh and blender manage sub-windows. I think we can add 2 types button in Windows menu for sub-windows:

  1. Split plotting window horizontally / vertically: Allow user to use different view directions to observe the mesh or solution data.
  2. Quick switch sub-windows layout: Allow user to re-arrange sub-windows in several pre-defined layout.

@yungyuc
Copy link
Member

yungyuc commented Jul 8, 2024

Perhaps we could also include a list of sub-windows under the windows menu. What do you think?

@j8xixo12
Copy link
Collaborator Author

j8xixo12 commented Jul 8, 2024

@yungyuc I'm not sure why we need a list of sub-windows ?
Is it to make user easier to toggle the sub-windows ?

@yungyuc
Copy link
Member

yungyuc commented Jul 8, 2024

Yes, a list of sub-windows helps a user select the current window more easily.

Most multi-window applications or applications supporting sub-windows has a list of windows or sub-windows under the windows menu, e.g., keynotes, safari, mails, blender, etc.

@j8xixo12
Copy link
Collaborator Author

j8xixo12 commented Jul 9, 2024

Yes, a list of sub-windows helps a user select the current window more easily.

Most multi-window applications or applications supporting sub-windows has a list of windows or sub-windows under the windows menu, e.g., keynotes, safari, mails, blender, etc.

Got it, this idea looks good to me!
Let me list the the items we have come up so far here:

  1. Split plotting window horizontally / vertically: Allow user to use different view directions to observe the mesh or solution data.
  2. Quick switch sub-windows layout: Allow user to re-arrange sub-windows in several pre-defined layout.
  3. Add list of sub-windows under Windows menu.

@tigercosmos, @YenPeiChen07 Do you have any other idea ?

@Gene0315
Copy link
Collaborator

For the plotting window, if it is a 3D model, maybe we can set the viewpoint with Azimuth and Elevation. What's more, we can use sliders to adjust the value of angle.
IMG_8546
ctrl-sliders-image

@yungyuc
Copy link
Member

yungyuc commented Jul 22, 2024

Having a control of the angle will be handy. We should also reference how other tools (like blender) handle this UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request viewer Visualize stuff
Projects
Status: Todo
Development

No branches or pull requests

5 participants