From 45d9714c45634361a86336a829547e8b73ca631e Mon Sep 17 00:00:00 2001 From: Zhou Hao Date: Tue, 18 May 2021 14:06:30 +0800 Subject: [PATCH] fix ineffectual assignment to err Signed-off-by: Zhou Hao --- test/framework/helm/release_manager.go | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/test/framework/helm/release_manager.go b/test/framework/helm/release_manager.go index ae124e0da..d1664cd1c 100644 --- a/test/framework/helm/release_manager.go +++ b/test/framework/helm/release_manager.go @@ -66,6 +66,9 @@ func (m *defaultReleaseManager) InstallRelease(chartRepo string, chartName strin installAction.ReleaseName = releaseName cp, err := installAction.ChartPathOptions.LocateChart(chartName, cli.New()) + if err != nil { + return nil, err + } chartRequested, err := loader.Load(cp) if err != nil { return nil, err @@ -85,6 +88,9 @@ func (m *defaultReleaseManager) UpgradeRelease(chartRepo string, chartName strin upgradeAction.Wait = true cp, err := upgradeAction.ChartPathOptions.LocateChart(chartName, cli.New()) + if err != nil { + return nil, err + } chartRequested, err := loader.Load(cp) if err != nil { return nil, err