[bgpmon]Sometimes when services shutdown, bgpmon throws errors

[dgsudharsan]

Description

Issue happens because bgpmon polls frr via vtysh every 15 seconds and when we stop bgp container, this may coincide with the polling scenario throwing the error below because if failure of vtysh command.

2024 Dec 13 15:06:19.102902 r-leopard-01 INFO systemd[1]: Stopping bgp.service - BGP container...
2024 Dec 13 15:06:19.109647 r-leopard-01 NOTICE admin: Stopping bgp service...
2024 Dec 13 15:06:19.131782 r-leopard-01 NOTICE admin: Warm boot flag: bgp true.
2024 Dec 13 15:06:19.136652 r-leopard-01 NOTICE admin: Fast boot flag: bgp false.
2024 Dec 13 15:06:19.141507 r-leopard-01 NOTICE admin: Kill zebra first
2024 Dec 13 15:06:19.229403 r-leopard-01 INFO bgp#supervisord: fpmsyncd Connection lost, reconnecting...
2024 Dec 13 15:06:19.229768 r-leopard-01 INFO bgp#supervisord: fpmsyncd Waiting for fpm-client connection...
2024 Dec 13 15:06:19.229822 r-leopard-01 INFO bgp#supervisord 2024-12-13 13:06:19,229 WARN exited: zebra (terminated by SIGKILL; not expected)
2024 Dec 13 15:06:19.321929 r-leopard-01 INFO bgp#supervisord 2024-12-13 13:06:19,321 WARN exited: bgpd (terminated by SIGKILL; not expected)
2024 Dec 13 15:06:19.629097 r-leopard-01 DEBUG container: container_stop: BEGIN
2024 Dec 13 15:06:19.629702 r-leopard-01 DEBUG container: read_data: config:True feature:bgp fields:[('set_owner', 'local'), ('no_fallback_to_local', False), ('state', 'disabled')] val:['local', False, 'enabled']
2024 Dec 13 15:06:19.630209 r-leopard-01 DEBUG container: read_data: config:False feature:bgp fields:[('current_owner', 'none'), ('remote_state', 'none'), ('container_id', '')] val:['none', 'none', '']
2024 Dec 13 15:06:19.630838 r-leopard-01 DEBUG container: container_stop: bgp: set_owner:local current_owner:none remote_state:none docker_id:bgp
2024 Dec 13 15:06:19.689567 r-leopard-01 NOTICE swss#portsyncd: :- onMsg: nlmsg type:16 key:Ethernet0 admin:1 oper:1 addr:1c:34:da:1d:40:00 ifindex:124 master:107 type:sx_netdev
2024 Dec 13 15:06:19.689996 r-leopard-01 NOTICE swss#portsyncd: :- onMsg: Publish Ethernet0(ok:up) to state db
2024 Dec 13 15:06:19.692589 r-leopard-01 INFO kernel: [ 1231.968483] device Ethernet0 entered promiscuous mode
2024 Dec 13 15:06:19.716492 r-leopard-01 ERR bgp#bgpmon: *ERROR* Failed with rc:1 when execute: ['vtysh', '-c', 'show bgp summary json']

Better approach will be to stop bgpmon before stopping FRR daemons.

Steps to reproduce the issue:

Describe the results you received:

Describe the results you expected:

Output of show version:

(paste your output here)

Output of show techsupport:

(paste your output here or download and attach the file here )

Additional information you deem important (e.g. issue happens only occasionally):