Skip to content

Commit 81032e3

Browse files
yejianquanmssonicbld
authored andcommitted
Add safe_reload and interface check for process monitoring and container check tests (#16252)
Description of PR Summary: Notice quite a lot flaky failures on PR test, https://elastictest.org/scheduler/testplan/676e75562c6c7b8d3e3bd8bf?testcase=process_monitoring%2Ftest_critical_process_monitoring.py&type=console Simply wait for 120s is not enough for multi-asic kvm testbeds, enhance the config_reload to use safe_reload to make sure the testbed is healthy. Approach What is the motivation for this PR? Notice quite a lot flaky failures on PR test, https://elastictest.org/scheduler/testplan/676e75562c6c7b8d3e3bd8bf?testcase=process_monitoring%2Ftest_critical_process_monitoring.py&type=console How did you do it? Simply wait for 120s is not enough for multi-asic kvm testbeds, enhance the config_reload to use safe_reload to make sure the testbed is healthy. How did you verify/test it? PR test will verify it. authorized by: [email protected]
1 parent 58ba938 commit 81032e3

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

tests/container_checker/test_container_checker.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ def config_reload_after_tests(duthosts, selected_rand_one_per_hwsku_hostname):
4949
for hostname in selected_rand_one_per_hwsku_hostname:
5050
duthost = duthosts[hostname]
5151
logger.info("Reload config on DuT '{}' ...".format(duthost.hostname))
52-
config_reload(duthost)
52+
config_reload(duthost, safe_reload=True, check_intf_up_ports=True, wait_for_bgp=True)
5353
postcheck_critical_processes_status(duthost, up_bgp_neighbors[duthost])
5454

5555

tests/process_monitoring/test_critical_process_monitoring.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
def config_reload_after_tests(duthosts, rand_one_dut_hostname):
3838
duthost = duthosts[rand_one_dut_hostname]
3939
yield
40-
config_reload(duthost)
40+
config_reload(duthost, safe_reload=True, check_intf_up_ports=True, wait_for_bgp=True)
4141

4242

4343
@pytest.fixture(autouse=True, scope='module')

0 commit comments

Comments
 (0)