Skip to content

Commit a2f22cd

Browse files
Update inner MAC addresses for PL test
Signed-off-by: Lawrence Lee <[email protected]>
1 parent 6afc030 commit a2f22cd

File tree

2 files changed

+26
-19
lines changed

2 files changed

+26
-19
lines changed

tests/dash/packets.py

+5-3
Original file line numberDiff line numberDiff line change
@@ -140,10 +140,10 @@ def inbound_pl_packets(config, inner_packet_type='udp', vxlan_udp_dport=4789):
140140
return gre_packet, masked_exp_packet
141141

142142

143-
def outbound_pl_packets(config, outer_encap, inner_packet_type='udp', vxlan_udp_dport=4789):
143+
def outbound_pl_packets(config, outer_encap, inner_packet_type='udp', vxlan_udp_dport=4789, vxlan_udp_sport=1234):
144144
inner_packet = generate_inner_packet(inner_packet_type)(
145-
eth_src=pl.ENI_MAC,
146-
eth_dst=pl.REMOTE_MAC,
145+
eth_src=pl.REMOTE_MAC,
146+
eth_dst=pl.ENI_MAC,
147147
ip_src=pl.VM1_CA,
148148
ip_dst=pl.PE_CA,
149149
)
@@ -155,6 +155,7 @@ def outbound_pl_packets(config, outer_encap, inner_packet_type='udp', vxlan_udp_
155155
ip_src=pl.VM1_PA,
156156
ip_dst=pl.APPLIANCE_VIP,
157157
udp_dport=vxlan_udp_dport,
158+
udp_sport=vxlan_udp_sport,
158159
with_udp_chksum=False,
159160
vxlan_vni=int(pl.VM_VNI),
160161
inner_frame=inner_packet
@@ -198,6 +199,7 @@ def outbound_pl_packets(config, outer_encap, inner_packet_type='udp', vxlan_udp_
198199
exp_inner_packet[scapy.UDP] = inner_packet[scapy.UDP]
199200

200201
exp_encap_packet = testutils.simple_gre_packet(
202+
eth_dst=config[REMOTE_PTF_MAC],
201203
eth_src=config[DUT_MAC],
202204
ip_src=pl.APPLIANCE_VIP,
203205
ip_dst=pl.PE_PA,

tests/dash/test_dash_privatelink.py

+21-16
Original file line numberDiff line numberDiff line change
@@ -51,28 +51,33 @@ def dpu_ip(duthost, dpu_index):
5151

5252

5353
@pytest.fixture(scope="module", autouse=True)
54-
def add_npu_static_routes(duthost, dpu_ip, dash_pl_config):
55-
cmds = []
56-
vm_nexthop_ip = get_interface_ip(duthost, dash_pl_config[LOCAL_DUT_INTF]).ip + 1
57-
pe_nexthop_ip = get_interface_ip(duthost, dash_pl_config[REMOTE_DUT_INTF]).ip + 1
58-
cmds.append(f"ip route replace {pl.APPLIANCE_VIP}/32 via {dpu_ip}")
59-
cmds.append(f"ip route replace {pl.VM1_PA}/32 via {vm_nexthop_ip}")
60-
cmds.append(f"ip route replace {pl.PE_PA}/32 via {pe_nexthop_ip}")
61-
logger.info(f"Adding static routes: {cmds}")
62-
duthost.shell_cmds(cmds=cmds)
54+
def add_npu_static_routes(duthost, dpu_ip, dash_pl_config, skip_config, skip_cleanup):
55+
if not skip_config:
56+
cmds = []
57+
vm_nexthop_ip = get_interface_ip(duthost, dash_pl_config[LOCAL_DUT_INTF]).ip + 1
58+
pe_nexthop_ip = get_interface_ip(duthost, dash_pl_config[REMOTE_DUT_INTF]).ip + 1
59+
cmds.append(f"ip route replace {pl.APPLIANCE_VIP}/32 via {dpu_ip}")
60+
cmds.append(f"ip route replace {pl.VM1_PA}/32 via {vm_nexthop_ip}")
61+
cmds.append(f"ip route replace {pl.PE_PA}/32 via {pe_nexthop_ip}")
62+
logger.info(f"Adding static routes: {cmds}")
63+
duthost.shell_cmds(cmds=cmds)
6364

6465
yield
6566

66-
cmds = []
67-
cmds.append(f"ip route del {pl.APPLIANCE_VIP}/32 via {dpu_ip}")
68-
cmds.append(f"ip route del {pl.VM1_PA}/32 via {vm_nexthop_ip}")
69-
cmds.append(f"ip route del {pl.PE_PA}/32 via {pe_nexthop_ip}")
70-
logger.info(f"Removing static routes: {cmds}")
71-
duthost.shell_cmds(cmds=cmds)
67+
if not skip_config and not skip_cleanup:
68+
cmds = []
69+
cmds.append(f"ip route del {pl.APPLIANCE_VIP}/32 via {dpu_ip}")
70+
cmds.append(f"ip route del {pl.VM1_PA}/32 via {vm_nexthop_ip}")
71+
cmds.append(f"ip route del {pl.PE_PA}/32 via {pe_nexthop_ip}")
72+
logger.info(f"Removing static routes: {cmds}")
73+
duthost.shell_cmds(cmds=cmds)
7274

7375

7476
@pytest.fixture(autouse=True)
75-
def common_setup_teardown(localhost, duthost, ptfhost, dpu_index):
77+
def common_setup_teardown(localhost, duthost, ptfhost, dpu_index, skip_config):
78+
if skip_config:
79+
return
80+
7681
logger.info(pl.ROUTING_TYPE_PL_CONFIG)
7782
base_config_messages = {
7883
**pl.APPLIANCE_CONFIG,

0 commit comments

Comments
 (0)