Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: test_config_fec_oper_mode doesn't handle port with FEC mode None #16120

Closed
bingwang-ms opened this issue Dec 17, 2024 · 2 comments
Closed
Assignees
Labels

Comments

@bingwang-ms
Copy link
Collaborator

Issue Description

There are two issues in this test

  1. The test test_config_fec_oper_mode is failing on some testbeds because the FEC mode is set to none for some ports. Setting the FEC mode to rs will bring the port down.
admin@str-msn2700-22:~$ show int status
     Interface            Lanes    Speed    MTU    FEC    Alias            Vlan    Oper    Admin             Type    Asym PFC
--------------  ---------------  -------  -----  -----  -------  --------------  ------  -------  ---------------  ----------
    Ethernet24      24,25,26,27     100G   9100   none     etp7           trunk      up       up  QSFP28 or later         off
    Ethernet28      28,29,30,31     100G   9100   none     etp8           trunk      up       up  QSFP28 or later         off
    Ethernet32      32,33,34,35     100G   9100   none     etp9           trunk      up       up  QSFP28 or later         off
    Ethernet36      36,37,38,39     100G   9100   none    etp10           trunk      up       up  QSFP28 or later         off
  1. The wait_until is not working properly. Test is not failing even if the port is not up. Please add an assert to check the result of wait_until.
    wait_until(30, 2, 0, duthost.is_interface_status_up, intf["interface"])

Results you see

Test failed on some testbeds.

Results you expected to see

Test should pass.

Is it platform specific

generic

Relevant log output

No response

Output of show version

No response

Attach files (if any)

No response

@bingwang-ms
Copy link
Collaborator Author

@vvolam, @prgeor Can you help take a look?

@vvolam
Copy link
Contributor

vvolam commented Feb 5, 2025

PRs to fix the issue are merged.

@vvolam vvolam closed this as completed Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants