Increase tolerance for 'ip-proto' hash_key on t2 topos #16188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'ip-proto' hash_key only has 8-bits of entropy which won't result in good distributions on systems with large ECMP groups
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'ip-proto' hash_key only has 8-bits of entropy which won't result in good distributions on systems with large ECMP groups.
T2 systems have a 24-way ecmp which sees some paths deviate from the 25% threshold for the
ip-protohash key.This change increases the tolerance just for
ip-protoandt2full topologies.For more details see #16147
Summary:
Fixes #16147
Type of change
Back port request