[action] [PR:24755] Fix skip condition for testQosSaiBufferPoolWatermark on DNX#24827
Merged
Merged
Conversation
…t#24755) What: Updates the skip condition for `qos/test_qos_sai.py::TestQosSai::testQosSaiBufferPoolWatermark` in tests/common/plugins/conditional_mark/tests_mark_conditions.yaml from a hard-coded platform list to `asic_subtype in ['broadcom-dnx']`. Why: T2 topologies were recently added to `constants['QOS_SAI_TOPO']`, which broke the previous platform-based skip; the test is invalid on DNX platforms since they do not support `sai_thrift_read_buffer_pool_watermark`. How: Replaced the `platform in [...]` condition with an `asic_subtype in ['broadcom-dnx']` condition while leaving the other skip clauses intact. Testing: Ran on a DNX SKU and confirmed the test is correctly skipped. Azure Pipelines CI green; approved by abdosi and vmittal-msft. Signed-off-by: Peter <peterbailey@arista.com> Signed-off-by: mssonicbld <sonicbld@microsoft.com>
12 tasks
Collaborator
Author
|
Original PR: #24755 |
Collaborator
Author
|
/azp run |
github-actions
Bot
requested review from
BYGX-wcr,
xwjiang-ms and
yutongzhang-microsoft
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
Author
|
This cherry pick PR has been opened for more than 3 days. The mssonicbld will attempt to retry. ---Powered by SONiC BuildBot
|
Collaborator
Author
|
/azpw retry |
Collaborator
Author
|
Retrying failed(or canceled) jobs... |
Collaborator
Author
|
Retrying failed(or canceled) stages in build 1120665: ✅Stage Test:
|
Collaborator
Author
|
@vmittal-msft The cherry pick PR didn't pass PR checker after retry. Left a comment in original PR #24755 to notify author. ---Powered by SONiC BuildBot
|
|
/azpw retry |
Collaborator
Author
|
Retrying failed(or canceled) jobs... |
Collaborator
Author
|
Retrying failed(or canceled) stages in build 1120665: ✅Stage Test:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
T2 Topos were recently added to constants['QOS_SAI_TOPO'] so the skip condition was not working as expected. This change replaces the current platform skip condition with a more strict asic based skip condition.
This test is invalid on DNX platforms as they do not support sai_thrift_read_buffer_pool_watermark.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
T2 Topos were recently added to constants['QOS_SAI_TOPO'] so the skip condition was not working as expected. This change replaces the current platform skip condition with a more strict asic based skip condition.
This test is invalid on DNX platforms as they do not support sai_thrift_read_buffer_pool_watermark.
How did you do it?
Changed the "platform in [" condition to "asic_subtype in" condition.
How did you verify/test it?
Ran on a DNX SKU to see the test is skipping.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation