[dash] Private Link CA to PA configuration fails due to irrelevant attributes

[oleksandrivantsiv]

SWSS when applying CA to PA configuration for the PL feature adds extra SAI_OUTBOUND_CA_TO_PA_ENTRY_ATTR_OVERLAY_DMAC and SAI_OUTBOUND_CA_TO_PA_ENTRY_ATTR_USE_DST_VNET_VNI attributes that are irrelevant attributes that causes SAI validation failure:

2024-09-11.12:15:03.414891|c|SAI_OBJECT_TYPE_VIP_ENTRY:{"switch_id":"oid:0x21000000000000","vip":"10.2.0.1"}|SAI_VIP_ENTRY_ATTR_ACTION=SAI_VIP_ENTRY_ACTION_ACCEPT
2024-09-11.12:15:03.429397|c|SAI_OBJECT_TYPE_DIRECTION_LOOKUP_ENTRY:{"switch_id":"oid:0x21000000000000","vni":"4321"}|SAI_DIRECTION_LOOKUP_ENTRY_ATTR_ACTION=SAI_DIRECTION_LOOKUP_ENTRY_ACTION_SET_OUTBOUND_DIRECTION
2024-09-11.12:15:03.432452|C|SAI_OBJECT_TYPE_VNET||oid:0xe00800000001d|SAI_VNET_ATTR_VNI=45654
2024-09-11.12:15:03.435982|C|SAI_OBJECT_TYPE_OUTBOUND_CA_TO_PA_ENTRY||{"dip":"10.1.1.5","dst_vnet_id":"oid:0xe00800000001d","switch_id":"oid:0x21000000000000"}|
	SAI_OUTBOUND_CA_TO_PA_ENTRY_ATTR_DASH_ENCAPSULATION=SAI_DASH_ENCAPSULATION_NVGRE|
	SAI_OUTBOUND_CA_TO_PA_ENTRY_ATTR_TUNNEL_KEY=100|
	SAI_OUTBOUND_CA_TO_PA_ENTRY_ATTR_UNDERLAY_DIP=101.1.2.3|
	SAI_OUTBOUND_CA_TO_PA_ENTRY_ATTR_ACTION=SAI_OUTBOUND_CA_TO_PA_ENTRY_ACTION_SET_PRIVATE_LINK_MAPPING|
	SAI_OUTBOUND_CA_TO_PA_ENTRY_ATTR_OVERLAY_DIP=2603:10e1:100:2::3401:203|
	SAI_OUTBOUND_CA_TO_PA_ENTRY_ATTR_OVERLAY_DIP_MASK=ffff:ffff:ffff:ffff:ffff:ffff:ffff:ffff|
	SAI_OUTBOUND_CA_TO_PA_ENTRY_ATTR_OVERLAY_SIP=fd41:108:20:abc:abc::|
	SAI_OUTBOUND_CA_TO_PA_ENTRY_ATTR_OVERLAY_SIP_MASK=ffff:ffff:ffff:ffff:ffff:ffff::|
	SAI_OUTBOUND_CA_TO_PA_ENTRY_ATTR_OVERLAY_DMAC=43:BE:65:25:FA:67|
	SAI_OUTBOUND_CA_TO_PA_ENTRY_ATTR_USE_DST_VNET_VNI=false
2024-09-11.12:15:03.438551|E|SAI_STATUS_FAILURE||-196603

2024 Sep 15 08:30:45.213972 sonic NOTICE syncd#syncd#SAI: [SAI_UTILS.NOTICE] ./src/mlnx_sai_utils.c[2225]- mlnx_bulk_statuses_print: [BULK_CREATE] 1 vnets: 1 success, 0 not executed, 0 failed
2024 Sep 15 08:30:45.214597 sonic NOTICE syncd#syncd#SAI: [SAI_UTILS_ETH.NOTICE] ./src/mlnx_sai_utils_dpu.c[708]- mlnx_create_bulk_objects: created vnets in bulk with NASA handler
2024 Sep 15 08:30:45.217549 sonic NOTICE syncd#syncd#SAI: [SAI_UTILS_ETH.NOTICE] ./src/mlnx_sai_utils_dpu.c[779]- mlnx_create_bulk_key_entries: create 1 outbound ca_to_pa entries in bulk
2024 Sep 15 08:30:45.218154 sonic ERR syncd#syncd#SAI: [SAI_UTILS.ERR] ./src/mlnx_sai_utils.c[1602]- sai_attribute_valid_condition_check: Attribute SAI_OUTBOUND_CA_TO_PA_ENTRY_ATTR_OVERLAY_DMAC doesn't match a valid conditions: {(SAI_OUTBOUND_CA_TO_PA_ENTRY_ATTR_ACTION : SET_TUNNEL_MAPPING)}
2024 Sep 15 08:30:45.218844 sonic ERR syncd#syncd#SAI: [SAI_UTILS_ETH.ERR] ./src/mlnx_sai_utils_dpu.c[634]- mlnx_bulk_create_validate_attribs_check_metadata: failed attribs check for attr_list index 0
2024 Sep 15 08:30:45.219814 sonic ERR swss#orchagent: :- flush_creating_entries: EntityBulker.flush create entries failed, number of entries to create: 1, status: SAI_STATUS_FAILURE
2024 Sep 15 08:30:45.220322 sonic NOTICE syncd#syncd#SAI: [SAI_UTILS.NOTICE] ./src/mlnx_sai_utils.c[2225]- mlnx_bulk_statuses_print: [BULK_CREATE] 1 outbound ca_to_pa: 0 success, 0 not executed, 1 failed
2024 Sep 15 08:30:45.221295 sonic ERR syncd#syncd#SAI: [SAI_UTILS_ETH.ERR] ./src/mlnx_sai_utils_dpu.c[797]- mlnx_create_bulk_key_entries: failed to create outbound ca_to_pa entries in bulk, err SAI_STATUS_FAILURE
2024 Sep 15 08:30:45.221400 sonic ERR syncd#syncd#SAI: :- sendApiResponse: api SAI_COMMON_API_BULK_CREATE failed in syncd mode: SAI_STATUS_FAILURE

According to the SAI headers definition both attributes can be configured only with SAI_OUTBOUND_CA_TO_PA_ENTRY_ACTION_SET_TUNNEL_MAPPING action and should not be used together with PL.

    /**
     * @brief Action parameter overlay destination MAC
     *
     * @type sai_mac_t
     * @flags CREATE_AND_SET
     * @default vendor
     * @validonly SAI_OUTBOUND_CA_TO_PA_ENTRY_ATTR_ACTION == SAI_OUTBOUND_CA_TO_PA_ENTRY_ACTION_SET_TUNNEL_MAPPING
     */
    SAI_OUTBOUND_CA_TO_PA_ENTRY_ATTR_OVERLAY_DMAC,

    /**
     * @brief Action parameter use dst VNET VNI
     *
     * @type bool
     * @flags CREATE_AND_SET
     * @default false
     * @validonly SAI_OUTBOUND_CA_TO_PA_ENTRY_ATTR_ACTION == SAI_OUTBOUND_CA_TO_PA_ENTRY_ACTION_SET_TUNNEL_MAPPING
     */
    SAI_OUTBOUND_CA_TO_PA_ENTRY_ATTR_USE_DST_VNET_VNI,