Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Requirements for a port to lua #102

Open
matu3ba opened this issue Jan 3, 2021 · 2 comments
Open

Question: Requirements for a port to lua #102

matu3ba opened this issue Jan 3, 2021 · 2 comments

Comments

@matu3ba
Copy link

matu3ba commented Jan 3, 2021

As there are now fairly complete status lines and packers: Would you consider a port to lua? What expectations would you have before porting to lua?

As I checked, you have only differenence in color definitions and the following lines between onehalfdark and onehalflight:

call s:h("Pmenu", s:fg, s:cursor_line, "")
call s:h("PmenuSel", s:bg, s:blue, "")
call s:h("PmenuSbar", "", s:cursor_line, "")
call s:h("PmenuThumb", "", s:comment_fg, "")
...
call s:h("Include", s:purple, "", "")

Meta: Is the last difference of purple intentional?

@sonph
Copy link
Owner

sonph commented Jan 15, 2021

Ahh good catch! Thanks! It's not intentional. I should fix that. AFAIK the Include highlight group is for the #include preprocessing directive. I consider that a keyword so the blue will need to be updated to purple.

@sonph
Copy link
Owner

sonph commented Jan 15, 2021

To answer your first question: I'm sure porting to lua isn't difficult as the theme barely contains any logic. However, if it ain't break, don't fix it. Also I no longer use Vim as my main text editor, so this is definitely not high on my list. If you (or anyone else) is willing to port it, I'll be more than happy to approve the change 🍻

sonph added a commit that referenced this issue Jan 15, 2021
The `Include` highlight group is for the `#include` preprocessing directive, which is considered a keyword so the blue will need to be updated to purple.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants