Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh Button for cached data from DS Service #57

Closed
AlexanderWert opened this issue Jul 25, 2014 · 5 comments
Closed

Refresh Button for cached data from DS Service #57

AlexanderWert opened this issue Jul 25, 2014 · 5 comments

Comments

@AlexanderWert
Copy link
Contributor

create a button to refresh the extensions-cache for extensions provided by DynamicSpotterService.

This is needed for example when dynamicSpotter server is restarted with a new set of extensions

@DenisKnoepfle
Copy link
Contributor

Currently if it is needed for testing purposes this can be achieved by

  • shutting down the DS service
  • closing an editor where the data has already been cached
  • reopen it and trying to access the extensions via the Add button

It will say there is no connection and clear all cached data. After DS service is restarted it will fetch the new data.

But sure, a button to do this would be more user-friendly and will be implemented soon.

@DenisKnoepfle
Copy link
Contributor

Before implementing this feature some questions concerning what the button will do should be clarified first:

  • Only clear cache?
  • What should happen with opened editors/views?
  • Should they be closed or tried to be refreshed (by rebuilding the editor input from file or from the current model inside the editor; if from file: what happens with unsaved data)?
  • What should happen if new extensions fetched from DS Service no longer match some configured extensions, e.g. due to a changed name or config parameters that were modified or no longer exist?
  • Should non-matching parameters just be ignored or should the whole editor input be declared invalid?

Until theses issues are clear I would suggest to implement the button in the context menu giving it only the functionality to "Clear Cache" (but loading outdated extensions from file will fail then until the complete validation and recovery of the input is implemented; currently it only checks whether the file can be parsed but not if occurring extensions have their parameters configured correctly).

@DenisKnoepfle DenisKnoepfle changed the title RefreshButton Refresh Button for cached data from DS Service Jul 26, 2014
@DenisKnoepfle
Copy link
Contributor

Enhancement is included in #60.

DenisKnoepfle added a commit to DenisKnoepfle/DynamicSpotter that referenced this issue Jul 26, 2014
Implemented the feature and made it available in the context menu when
at least one project is selected. Currently there is a bug when
right-clicking on the project which has not been selected before. This
problem is addressed in sopeco#63.

Change-Id: Ic4c9cc663c06f9d49532f370789dbd762c3d8789
Signed-off-by: Denis Knoepfle <[email protected]>
DenisKnoepfle added a commit to DenisKnoepfle/DynamicSpotter that referenced this issue Jul 27, 2014
Implemented the feature and made it available in the context menu when
at least one project is selected. Currently there is a bug when
right-clicking on the project which has not been selected before. This
problem is addressed in sopeco#63.

Change-Id: Ic4c9cc663c06f9d49532f370789dbd762c3d8789
Signed-off-by: Denis Knoepfle <[email protected]>
@DenisKnoepfle
Copy link
Contributor

Updated info message in #72, but ExtensionItem needs refactoring first in order to fully clear all cached data. This will be addressed after #51, #68 and #69.

AlexanderWert pushed a commit to AlexanderWert/DynamicSpotter that referenced this issue Aug 5, 2014
Implemented the feature and made it available in the context menu when
at least one project is selected. Currently there is a bug when
right-clicking on the project which has not been selected before. This
problem is addressed in sopeco#63.

Change-Id: Ic4c9cc663c06f9d49532f370789dbd762c3d8789
Signed-off-by: Denis Knoepfle <[email protected]>
DenisKnoepfle added a commit that referenced this issue Aug 5, 2014
Implemented the feature and made it available in the context menu when
at least one project is selected. Currently there is a bug when
right-clicking on the project which has not been selected before. This
problem is addressed in #63.

Change-Id: Ic4c9cc663c06f9d49532f370789dbd762c3d8789
Signed-off-by: Denis Knoepfle <[email protected]>
@DenisKnoepfle
Copy link
Contributor

Removed caching inside extension items in #95.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants