Fix version check for entrypoint plugins with unequal project/package names #2594
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2593.
This changeset swallows all exceptions when trying to determine the version of an
EntryPointPlugin
, as there are more failure cases than what catchingValueError
specifically covers, and allowing those exceptions to propagate breaks plugin reloading.Checklist
make qa
(runsmake lint
andmake test
)1388 passed, 8 xfailed, 1 warning in 45.44s