Tweak README to reflect conflict? flag changes #1092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since `Oban.insert` changed its behaviour regarding the conflict? when failing to acquire the respective advisory lock the README should reflect that.
sorentwo
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
Oban.insertchanged its behaviour regarding the conflict? when failing to acquire the respective advisory lock the README should reflect that.I'm not entirely sure how to phrase some additional advice to elaborate the internals, especially the fact that there is no guarantee that a job is inserted while it somehow feels like it.
It may also be a good idea to underline issues when using a Repeatable Read Isolation Level because Oban will be unable to see conflicting jobs originating from concurrent transactions.