Skip to content
This repository has been archived by the owner on May 29, 2018. It is now read-only.

TLS (and boot2docker) support #169

Open
xizhao opened this issue Jun 30, 2015 · 0 comments
Open

TLS (and boot2docker) support #169

xizhao opened this issue Jun 30, 2015 · 0 comments

Comments

@xizhao
Copy link
Contributor

xizhao commented Jun 30, 2015

Boot2Docker enables TLS by default, and with the way that toolchain.dc is currently implemented it only initiates a regular docker client.

Changes proposed to:
https://sourcegraph.com/sourcegraph.com/sourcegraph/srclib@4ede24c6a6b442b551050243498c567fe7f86165/.tree/toolchain/docker.go#def=/sourcegraph.com/sourcegraph/srclib@4ede24c6a6b442b551050243498c567fe7f86165/.GoPackage/sourcegraph.com/sourcegraph/srclib/toolchain/.def/newDockerClient&startbyte=244&endbyte=605

  1. check if url starts with or ENV.DOCKER_TLS_VERIFY or ENV.DOCKER_CERT_PATH is set
  2. if so use return NewTLSClient w/ relevant vars set like so:
    https://github.com/fsouza/go-dockerclient#using-with-boot2docker
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant