Merge pull request #9 from sourcerer-io/develop

feat: Releasing latest changes.

Author: sergey48k

README.md

@@ -22,13 +22,11 @@ Hall-of-fame code is entirely open source. You can run it in Google cloud yourse
 4. You should see code to insert in your README.md. It will look something like this:
 
 ```
-<a href="https://sourcerer.io/fame/$USER/$OWNER/$REPO/links/0"
-  ><img src="https://sourcerer.io/fame/$USER/$OWNER/$REPO/images/0" height="90px" hspace="4"></a>
+[![](https://sourcerer.io/fame/$USER/$OWNER/$REPO/images/0)](https://sourcerer.io/fame/$USER/$OWNER/$REPO/links/0)
 
 ...
 
-<a href="https://sourcerer.io/fame/$USER/$OWNER/$REPO/links/7"
-  ><img src="https://sourcerer.io/fame/$USER/$OWNER/$REPO/images/7" height="90px" hspace="4"></a>
+[![](https://sourcerer.io/fame/$USER/$OWNER/$REPO/images/7)](https://sourcerer.io/fame/$USER/$OWNER/$REPO/links/7)
 ```
 Paste that code into your README.md, and you should be good to go. Hall-of-fame will take care of the rest.
 
@@ -52,4 +50,11 @@ Note that Hall-of-fame will use your GitHub token for hourly updates via GitHub
 
 Contribute to Hall-of-fame by all means. Here is the live Hall-of-fame for this repo:
 
-<a href="https://sourcerer.io/fame/sergey48k/sourcerer-io/hall-of-fame/links/0"><img src="https://sourcerer.io/fame/sergey48k/sourcerer-io/hall-of-fame/images/0" height="90px" hspace="4" /></a><a href="https://sourcerer.io/fame/sergey48k/sourcerer-io/hall-of-fame/links/1"><img src="https://sourcerer.io/fame/sergey48k/sourcerer-io/hall-of-fame/images/1" height="90px" hspace="4" /></a><a href="https://sourcerer.io/fame/sergey48k/sourcerer-io/hall-of-fame/links/2"><img src="https://sourcerer.io/fame/sergey48k/sourcerer-io/hall-of-fame/images/2" height="90px" hspace="4" /></a><a href="https://sourcerer.io/fame/sergey48k/sourcerer-io/hall-of-fame/links/3"><img src="https://sourcerer.io/fame/sergey48k/sourcerer-io/hall-of-fame/images/3" height="90px" hspace="4" /></a><a href="https://sourcerer.io/fame/sergey48k/sourcerer-io/hall-of-fame/links/4"><img src="https://sourcerer.io/fame/sergey48k/sourcerer-io/hall-of-fame/images/4" height="90px" hspace="4" /></a><a href="https://sourcerer.io/fame/sergey48k/sourcerer-io/hall-of-fame/links/5"><img src="https://sourcerer.io/fame/sergey48k/sourcerer-io/hall-of-fame/images/5" height="90px" hspace="4" /></a><a href="https://sourcerer.io/fame/sergey48k/sourcerer-io/hall-of-fame/links/6"><img src="https://sourcerer.io/fame/sergey48k/sourcerer-io/hall-of-fame/images/6" height="90px" hspace="4" /></a><a href="https://sourcerer.io/fame/sergey48k/sourcerer-io/hall-of-fame/links/7"><img src="https://sourcerer.io/fame/sergey48k/sourcerer-io/hall-of-fame/images/7" height="90px" hspace="4" /></a>
+[![](https://sourcerer.io/fame/sergey48k/sourcerer-io/hall-of-fame/images/0)](https://sourcerer.io/fame/sergey48k/sourcerer-io/hall-of-fame/links/0)
+[![](https://sourcerer.io/fame/sergey48k/sourcerer-io/hall-of-fame/images/1)](https://sourcerer.io/fame/sergey48k/sourcerer-io/hall-of-fame/links/1)
+[![](https://sourcerer.io/fame/sergey48k/sourcerer-io/hall-of-fame/images/2)](https://sourcerer.io/fame/sergey48k/sourcerer-io/hall-of-fame/links/2)
+[![](https://sourcerer.io/fame/sergey48k/sourcerer-io/hall-of-fame/images/3)](https://sourcerer.io/fame/sergey48k/sourcerer-io/hall-of-fame/links/3)
+[![](https://sourcerer.io/fame/sergey48k/sourcerer-io/hall-of-fame/images/4)](https://sourcerer.io/fame/sergey48k/sourcerer-io/hall-of-fame/links/4)
+[![](https://sourcerer.io/fame/sergey48k/sourcerer-io/hall-of-fame/images/5)](https://sourcerer.io/fame/sergey48k/sourcerer-io/hall-of-fame/links/5)
+[![](https://sourcerer.io/fame/sergey48k/sourcerer-io/hall-of-fame/images/6)](https://sourcerer.io/fame/sergey48k/sourcerer-io/hall-of-fame/links/6)
+[![](https://sourcerer.io/fame/sergey48k/sourcerer-io/hall-of-fame/images/7)](https://sourcerer.io/fame/sergey48k/sourcerer-io/hall-of-fame/links/7)

fame/avatar.py

@@ -101,8 +101,10 @@ def _make_badge(self):
 
 
 class AvatarAdorner:
-
     """AvatarAdorner adorns avatars with badges."""
+
+    PADDING = 10  # Padding on each side of an adorned avatar.
+
     def init_with_face(self, face_url):
         self.svg = ElementTree.fromstring(SVG_GITHUB)
         self._init_face_image()
@@ -185,16 +187,11 @@ def _make_badge(self):
         face_w, face_h = self.face_w, self.face_h
         badge_w, badge_h = self.badger.badge_w, self.badger.badge_h
 
-        w = face_w
         h = face_h + badge_h + self.badger.badge_off
+        w = max(face_w, badge_w) + AvatarAdorner.PADDING * 2
 
-        if badge_w > face_w:
-            # Badge is wider than face, center face with respect to badge.
-            self.face_svg.set('x', '%.02f' % ((badge_w - face_w) / 2))
-            w = badge_w
-        else:
-            # Face is wider than badge, center badge with respect to face.
-            badge_svg.set('x', '%.02f' % ((face_w - badge_w) / 2))
+        self.face_svg.set('x', '%.02f' % ((w - face_w) / 2))  # Center face.
+        badge_svg.set('x', '%.02f' % ((w - badge_w) / 2))  # Center badge.
 
         self.svg.set('viewBox', '0 0 %.02f %.02f' % (w, h))
         badge_svg.set('y', '%.02f' % (face_h + self.badger.badge_off))

fame/glory.py

@@ -120,7 +120,7 @@ def _issue_badges(self, trending, new_faces, top_guns):
         # Generate a test HTML.
         f = io.StringIO()
         for i in range(len(profile_urls)):
-            h = '<a href="%s"><img src="images/%d.svg"></a>\n'
+            h = '<a href="%s"><img src="images/%d.svg"></a>'
             f.write(h % (profile_urls[i], i))
         test_html_path = self._get_test_html_path(temp=True)
         storage.save_file(test_html_path, f.getvalue(), 'text/html')
@@ -139,7 +139,7 @@ def _map_users_to_sourcerer(self, github_usernames):
         url = self._get_sourcerer_mapping_url(github_usernames)
         data = urlopen(url).read().decode()
         parsed = json.loads(data)
-        self.user_mapping = {k: v for k,v in parsed.items() if v}
+        self.user_mapping = {k: v for k, v in parsed.items() if v}
 
     def _map_to_sourcerer(self, github_username):
         if github_username not in self.user_mapping:
@@ -168,7 +168,7 @@ def _cleanup(self):
         temp_image_dir = self._get_image_dir(temp=True)
         storage.make_dirs(temp_image_dir)
 
-        image_dir = self._get_image_dir(temp=False) 
+        image_dir = self._get_image_dir(temp=False)
         storage.make_dirs(image_dir)
 
     def _install(self):

fame/ssl_hack.py

@@ -8,6 +8,7 @@
 
 import ssl
 
+
 def disable_ssl_host_check():
     """Never use in production!"""
     try:

fame/storage/google_cloud_storage.py

@@ -3,8 +3,6 @@
 __author__ = 'Sergey Surkov'
 __copyright__ = '2018 Sourcerer, Inc'
 
-from datetime import datetime
-
 import pytz
 from google.api_core.exceptions import NotFound
 from google.cloud import storage as gstorage