Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build_wasm actions are failing with a pydantic error #2678

Closed
ctb opened this issue Jul 10, 2023 · 2 comments
Closed

build_wasm actions are failing with a pydantic error #2678

ctb opened this issue Jul 10, 2023 · 2 comments

Comments

@ctb
Copy link
Contributor

ctb commented Jul 10, 2023

e.g. https://github.com/sourmash-bio/sourmash/actions/runs/5512489542/jobs/10049386734?pr=2673 on PR #2673:

 pydantic.errors.PydanticUserError: If you use `@root_validator` with pre=False (the default) you MUST specify `skip_on_failure=True`. Note that `@root_validator` is deprecated and should be replaced with `@model_validator`.

For further information visit https://errors.pydantic.dev/2.0.2/u/root-validator-pre-skip

cc @luizirber
@ctb
Copy link
Contributor Author

ctb commented Jul 11, 2023

attempting fix in #2673 commit 0608088 with forcing pydantic < 2, per numpy/numpy#24091 via numpy/numpy#24088.

@ctb
Copy link
Contributor Author

ctb commented Jul 11, 2023

Yep fixed!

@ctb ctb closed this as completed Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ctb