Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sourmash v4.8.3 release - checklist and release notes #2718

Closed
13 tasks done
ctb opened this issue Aug 17, 2023 · 9 comments
Closed
13 tasks done

sourmash v4.8.3 release - checklist and release notes #2718

ctb opened this issue Aug 17, 2023 · 9 comments

Comments

@ctb
Copy link
Contributor

ctb commented Aug 17, 2023 •
edited
Loading

Release candidate testing:

  • Command line tests pass for a release candidate
  • All eight release candidate wheels are built

Releasing to PyPI:

  • RC tag(s)s deleted on github
  • Release tag cut
  • Release notes written
  • All eight release wheels built
  • Release wheels uploaded to pypi
  • tar.gz distribution uploaded to pypi

After release to PyPI and conda-forge/bioconda packages built:
@ctb
Copy link
Contributor Author

ctb commented Aug 17, 2023 •
edited
Loading

Release notes

Minor new features:

Cleanup and documentation updates:

Developer updates:

Dependabot updates:

@ctb ctb mentioned this issue Aug 17, 2023
Merged
@ctb
Copy link
Contributor Author

ctb commented Aug 17, 2023 •
edited
Loading

note from testenv2 run: we get,

DEPRECATION: git+https://github.com/sourmash-bio/sourmash.git@release/v4.8.3#egg
=sourmash[test] contains an egg fragment with a non-PEP 508 name pip 25.0 will enforce this behaviour change. A possible replacement is to use the req @ url syntax, and remove the egg fragment. Discussion can be found at pypa/pip#11617

ctb added a commit that referenced this issue Aug 17, 2023
@ctb
4.8.3 release branch (#2719)
52449f6 
ref #2718
@ctb
Copy link
Contributor Author

ctb commented Aug 17, 2023

note also:

an unsupported platform tag emscripten ...
blocks upload to pypi, per #2553. So I delete that wheel before using twine to upload wheels.

@ctb
Copy link
Contributor Author

ctb commented Aug 17, 2023

bioconda PR: bioconda/bioconda-recipes#42538

@ctb
Copy link
Contributor Author

ctb commented Aug 17, 2023

conda-forge PR: conda-forge/sourmash-minimal-feedstock#51

@ctb
Copy link
Contributor Author

ctb commented Aug 17, 2023

https://github.com/sourmash-bio/sourmash/releases/tag/v4.8.3 🎉

@ctb ctb closed this as completed Aug 17, 2023
@luizirber
Copy link
Member

pyodide PR: pyodide/pyodide#4075
nixpkgs PR: NixOS/nixpkgs#230596

@ctb
Copy link
Contributor Author

ctb commented Aug 27, 2023

@luizirber should I add pyodide & nixpkgs to release checklist?

@luizirber
Copy link
Member

@luizirber should I add pyodide & nixpkgs to release checklist?

I'm a maintainer for the nixpkgs package, and it should auto-create a PR when a new version is available (🤞 ). So, good as informational, but will mostly automerge?

for pyodide it is manual, so yes, probably good to be in the release checklist

@ctb ctb mentioned this issue Sep 25, 2023
Merged
ctb added a commit that referenced this issue Sep 27, 2023
@ctb
MRG: minor updates to release procedure after 4.8.4 (#2783)
f19af8c 
This PR:
- changes `git checkout -b` to `git switch -c`
- removes unused `testenv4`
- adds checklist items for spack and pyodide
- adds more info on version bump to v+1-dev

Fixes #2517
Addresses
#2718 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@luizirber @ctb