Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rust lints beta CI check is failing on latest #3261

Closed
ctb opened this issue Jul 23, 2024 · 1 comment
Closed

rust lints beta CI check is failing on latest #3261

ctb opened this issue Jul 23, 2024 · 1 comment

Comments

@ctb
Copy link
Contributor

ctb commented Jul 23, 2024 

 Error:   --> src/core/src/storage.rs:90:19
   |
90 | pub(crate) struct StorageInfo {
   |                   ^^^^^^^^^^^
   |
   = note: `-D dead-code` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(dead_code)]`
@ctb ctb changed the title rust lints beta CI check is failing rust lints beta CI check is failing on latest Jul 23, 2024
@luizirber luizirber mentioned this issue Jul 24, 2024
Merged
luizirber added a commit that referenced this issue Jul 27, 2024
@luizirber
feat: RocksDB storage and self-contained RevIndex with internal stora…
d516811 
…ge (#3250)

Implement a RocksDB storage for making a self-contained RevIndex
(containing both the revindex and the sigs needed for gather) and
support more flexible RocksDB sketch storage.

- Remove branchwater dependency on `rkyv`, make it optional
- Move most RocksDB initialization to the new `storage::rocksdb` module
- Disable `prepare_for_bulk_load`, it is a footgun for large index
construction
- make `sourmash::storage::StorageError` non-exhaustive
- remove unused `StorageInfo` (#3261)
@luizirber
Copy link
Member

Fixed in #3250

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@luizirber @ctb