Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue with changing config because attributes saved as node.normal #392

Open
ayanich opened this issue Mar 14, 2019 · 2 comments
Open

issue with changing config because attributes saved as node.normal #392

ayanich opened this issue Mar 14, 2019 · 2 comments
Labels
Bug Something isn't working hacktoberfest An issue highlighted for the digital ocean Hacktoberfest Event Help Wanted Assistance is required to resolve this issue Priority: High Critical work that must be completed

Comments

@ayanich
Copy link

ayanich commented Mar 14, 2019

Cookbook version

3.0.0

Chef-client version

12+

Platform Details

n/a

Scenario:

updating the config in the recipe does not ever change the config on a server, because the attributes are initially saved to node.normal level at https://github.com/sous-chefs/redisio/blob/master/recipes/configure.rb#L75

I can understand not wanting to restart a running redis when a config change happens, but this currently limits the updating the configs on a box without doing a knife exec ... to delete the attributes.

Steps to Reproduce:

change one of these default_settings in https://github.com/sous-chefs/redisio/blob/master/attributes/default.rb#L87 in your wrapper cookbook, and when you release your changes, they do not get reflected on the server because they've already been set at node.normal level. relevant files are in /etc/redis/

Expected Result:

files in /etc/redis to get updated with new configs from default_settings attributes

Actual Result:

changes do not get reflected

@ayanich ayanich changed the title issue with changing config because attributes saves as node.normal issue with changing config because attributes saved as node.normal Mar 14, 2019
@xorima xorima added Bug Something isn't working Help Wanted Assistance is required to resolve this issue Priority: High Critical work that must be completed labels May 11, 2019
@popsikle
Copy link
Contributor

popsikle commented Jan 9, 2020

Once a redisserver[xx] entry is configured a breadcrumb is dropped to prevent writing the config file again. https://github.com/sous-chefs/redisio/blob/master/providers/configure.rb#L297 so even if you update attributes (or force override or something) it will not rewrite a config file, this is a design choice and not a bug, imho.

@ayanich
Copy link
Author

ayanich commented Apr 23, 2020

this is not the case when you turn breadcrumb file off. cookbooks shouldnt be using node.normal, that said, i dont really use this cookbook anymore.

@ramereth ramereth added the hacktoberfest An issue highlighted for the digital ocean Hacktoberfest Event label Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working hacktoberfest An issue highlighted for the digital ocean Hacktoberfest Event Help Wanted Assistance is required to resolve this issue Priority: High Critical work that must be completed
Projects
None yet
Development

No branches or pull requests

4 participants