Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tile Migration is not working #5565

Open
UrPrice opened this issue Dec 7, 2024 · 4 comments · May be fixed by #5572
Open

Tile Migration is not working #5565

UrPrice opened this issue Dec 7, 2024 · 4 comments · May be fixed by #5572

Comments

@UrPrice
Copy link

UrPrice commented Dec 7, 2024

Description

After merged space-wizards/space-station-14#33422 when I started loading my game maps, I ran into this issue where there were tiles named PlatingBurnt and FloorSteelBurnt that were supposed to migrate when loading (doesn't matter if it's the loadmap command or mapping command) - but they ain't migrating as intended. And that's causing an error like:

[INFO] con: localhost@UrPrice2:savemap 5 /Maps220/ss220-box.yml
[ERRO] con: localhost@UrPrice2: ExecuteError - savemap 5 /Maps220/ss220-box.yml:
System.ArgumentException: An item with the same key has already been added. Key: 136
   at System.Collections.Generic.Dictionary`2.TryInsert(TKey key, TValue value, InsertionBehavior behavior)
   at System.Collections.Generic.Dictionary`2.Add(TKey key, TValue value)
   at Robust.Server.GameObjects.MapLoaderSystem.WriteTileMapSection(MappingDataNode rootNode, List`1 entities) in D:\SS220\SS220_work\work\RobustToolbox\Robust.Server\GameObjects\EntitySystems\MapLoaderSystem.cs:line 1021
   at Robust.Server.GameObjects.MapLoaderSystem.GetSaveData(EntityUid uid) in D:\SS220\SS220_work\work\RobustToolbox\Robust.Server\GameObjects\EntitySystems\MapLoaderSystem.cs:line 950
   at Robust.Server.GameObjects.MapLoaderSystem.Save(EntityUid uid, String ymlPath) in D:\SS220\SS220_work\work\RobustToolbox\Robust.Server\GameObjects\EntitySystems\MapLoaderSystem.cs:line 204
   at Robust.Server.GameObjects.MapLoaderSystem.SaveMap(MapId mapId, String ymlPath) in D:\SS220\SS220_work\work\RobustToolbox\Robust.Server\GameObjects\EntitySystems\MapLoaderSystem.cs:line 226
   at Robust.Server.Console.Commands.SaveMap.Execute(IConsoleShell shell, String argStr, String[] args) in D:\SS220\SS220_work\work\RobustToolbox\Robust.Server\Console\Commands\MapCommands.cs:line 206
   at Robust.Server.Console.ServerConsoleHost.ExecuteInShell(IConsoleShell shell, String command) in D:\SS220\SS220_work\work\RobustToolbox\Robust.Server\Console\ServerConsoleHost.cs:line 126

Turns out, the tile migration itself ain't happening, which leads to the error of trying to add a key to the dictionary for a non-existent tile prototype. Can you please fix the tile migration so we don't have trouble saving them?

Reproduction
You can see this happening right now on the map Maps/Salvages/small_cargo.yml
Load this salvage and try save

Screenshots
not req
@UrPrice
Copy link
Author

UrPrice commented Dec 15, 2024

💀

@UrPrice
Copy link
Author

UrPrice commented Dec 15, 2024

@PJB3005 @DrSmugleaf FYI pls
We cant update our server for mappers with this issue, bcz in this case they cant save maps..

@PJB3005
Copy link
Member

PJB3005 commented Dec 15, 2024

Do not ping staff directly

@metalgearsloth
Copy link
Contributor

Wrong repo brother

@metalgearsloth metalgearsloth transferred this issue from space-wizards/space-station-14 Dec 21, 2024
@ElectroJr ElectroJr linked a pull request Dec 23, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor map loading & saving ElectroJr/RobustToolbox
3 participants
@PJB3005 @metalgearsloth @UrPrice