Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PlacementManager's Erase method is behaving strangely #5575

Closed
southbridge-fur opened this issue Dec 26, 2024 · 4 comments · Fixed by #5576
Closed

PlacementManager's Erase method is behaving strangely #5575

southbridge-fur opened this issue Dec 26, 2024 · 4 comments · Fixed by #5576

Comments

@southbridge-fur
Copy link
Contributor

When modifying maps and using the PlacementManager's entity-based rectangular erase method, the coordinates of the erasing rectangle appear to be very off.

This area in the video is near 0,0 for the map.
https://github.com/user-attachments/assets/dbccbef7-ea15-4efc-982e-dbe9807e8248

I'm going to guess it has something to do with this change PlacementManager.cs
@southbridge-fur
Copy link
Contributor Author

This issue is not present in the tile-based erasing method.

@southbridge-fur
Copy link
Contributor Author

I've already fixed it, gonna submit a PR in a moment

@southbridge-fur
Copy link
Contributor Author

My fix isn't perfect ack

@southbridge-fur
Copy link
Contributor Author

An issue I discovered in my fix also exists in the regular implementation as well, so my fix isn't bad! However now I want to fix the other issue

@southbridge-fur southbridge-fur mentioned this issue Dec 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

PlacementManager CurrentEraserMouseCoordinates fix southbridge-fur/RobustToolbox
1 participant
@southbridge-fur