Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider adding Entity<T> yaml serialization support #5580

Open
ElectroJr opened this issue Dec 27, 2024 · 1 comment
Open

Consider adding Entity<T> yaml serialization support #5580

ElectroJr opened this issue Dec 27, 2024 · 1 comment
Labels
Area: Serialization Difficulty: 3-Hard Extensive codebase knowledge required. Issue: Feature This issue is a feature request Priority: 3-Not Required

Comments

@ElectroJr
Copy link
Member

ElectroJr commented Dec 27, 2024 •
edited
Loading

Would be nice to have, but not trivial to support, because entity/component data is read sequentially. So you might be parsing an entity & its data-fields before the entity being referenced has been loaded, so you don't know yet know whether or not it has the component.

See #4855 and space-wizards/space-station-14/issues/24078
@ElectroJr ElectroJr added Issue: Feature This issue is a feature request Priority: 3-Not Required Area: Serialization Difficulty: 3-Hard Extensive codebase knowledge required. labels Dec 27, 2024
@ElectroJr ElectroJr changed the title Add Entity<T> yaml serialization support Consider adding Entity<T> yaml serialization support Dec 27, 2024
@ElectroJr ElectroJr changed the title Consider adding Entity<T> yaml serialization support Consider adding Entity<T> yaml serialization support Dec 27, 2024
@ElectroJr ElectroJr mentioned this issue Dec 27, 2024
Closed
@PJB3005
Copy link
Member

PJB3005 commented Dec 28, 2024

Yeah I'm not sure this is actually a good idea, kinda violates ECS IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: Serialization Difficulty: 3-Hard Extensive codebase knowledge required. Issue: Feature This issue is a feature request Priority: 3-Not Required
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@PJB3005 @ElectroJr