Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feedback from PJB #23

Open
juliangiebel opened this issue Jun 12, 2024 · 0 comments
Open

Feedback from PJB #23

juliangiebel opened this issue Jun 12, 2024 · 0 comments

Comments

@juliangiebel
Copy link
Collaborator

  1. stop using EFCore .Find, this error clearly shows it's a poorly designed API that should be marked as obsolete
  2. you need to use async more, there's a ton of cases where you're doing DB ops without async which is bad for perf (doesn't matter in your case but bad form)
  3. fix the nullability on the other DbSets
@juliangiebel juliangiebel changed the title PJB feedback Feedback from PJB Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@juliangiebel