Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to perform schema validation for config CRUD APIs #1660

Open
YourTechBud opened this issue Mar 8, 2023 · 0 comments
Open

Ability to perform schema validation for config CRUD APIs #1660

YourTechBud opened this issue Mar 8, 2023 · 0 comments
Assignees
@shubham4443
Labels
p/low
Milestone
v0.22.0

Comments

@YourTechBud
Copy link
Collaborator

YourTechBud commented Mar 8, 2023 •
edited
Loading

Challenge

  • No way to do a schema check for configs being written when using non K8s config adapters.

Solution

  1. Add a json schema / openapi validation step for the apply config endpoint.
  2. We can use the JSON schema reflection library to figure out the schema of a source when it registers itself with the Source Manager.
  3. Source Manager can store the json schema generated in a global map against the gvr
  4. Handler for config apply endpoint can fetch this jsonschema from the Source Manager App before passing the data to the ConfigManager
@YourTechBud YourTechBud converted this from a draft issue Mar 8, 2023
@YourTechBud YourTechBud added this to the v0.22.0 milestone Mar 8, 2023
@YourTechBud YourTechBud moved this from 📋 Backlog to 🔖 Ready in @SpaceCloudIO's Backlog Jun 17, 2023
@YourTechBud YourTechBud moved this from 🔖 Ready to 📋 Backlog in @SpaceCloudIO's Backlog Jun 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shubham4443 shubham4443

Labels
p/low
Projects
@SpaceCloudIO's Backlog
Status: 📋 Backlog
Milestone
v0.22.0
Development

No branches or pull requests
2 participants
@YourTechBud @shubham4443