Skip to content

Commit da10d43

Browse files
committed
Backport 6248: Fix response data slice too small (#6249)
1 parent 334d6cc commit da10d43

File tree

4 files changed

+12
-4
lines changed

4 files changed

+12
-4
lines changed

CHANGELOG.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,13 @@
22

33
See [RELEASE](./RELEASE.md) for workflow instructions.
44

5+
## Release v1.6.6-hotfix1
6+
7+
### Improvements
8+
9+
* [#6248](https://github.com/spacemeshos/go-spacemesh/pull/6248) Fixed node not being able to handle more than 6.55M
10+
ATXs per epoch.
11+
512
## Release v1.6.6
613

714
### Improvements

fetch/wire_types.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,8 @@ type MaliciousIDs struct {
121121

122122
type EpochData struct {
123123
// When changing this value also check
124-
// - the size of `ResponseMessage` above
124+
// - the size of `ResponseMessage.Data` above
125+
// - the size of `Response.Data` in `p2p/server/server.go`
125126
// - the size of `NodeIDs` in `MaliciousIDs` above
126127
// - the size of `Set` in `EpochActiveSet` in common/types/activation.go
127128
// - the size of `EligibilityProofs` in the type `Ballot` in common/types/ballot.go

p2p/server/server.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ func (err *ServerError) Error() string {
138138
// Response is a server response.
139139
type Response struct {
140140
// keep in line with limit of ResponseMessage.Data in `fetch/wire_types.go`
141-
Data []byte `scale:"max=209715200"` // 200 MiB > 6.0 mio ATX * 32 bytes per ID
141+
Data []byte `scale:"max=272629760"` // 260 MiB > 8.0 mio ATX * 32 bytes per ID
142142
Error string `scale:"max=1024"` // TODO(mafa): make error code instead of string
143143
}
144144

p2p/server/server_scale.go

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)